Description: ------------ CSS @media rules can contain nested CSS definitions. 2 sniffs are not prepared for that, patch attached. See also the example CSS test snippet. Test script: --------------- @media screen and (max-device-width: 769px) { header #logo img { max-width: 100%; } } Expected result: ---------------- All CSS sniffs should pass. Actual result: -------------- Squiz_Sniffs_CSS_IndentationSniff and Squiz_Sniffs_CSS_MissingColonSniff report false positives.

Added patch phpcs-css-media.patch.

Added patch phpcs-css-media.patch.

Fixed in Git: https://github.com/squizlabs/PHP_CodeSniffer/commit/440d99d022314ae187b3a39f2 826b129a6d97806 Thanks again for another great patch.

Here is a followup patch that addresses some white space issues in the sniffs. I think a nested rule definition should not be treated as class definition. Therefore blank lines should be allowed in it. CSS Test sample: -------------------- @media screen and (max-device-width: 769px) { header #logo img { max-width: 100%; } .inner { min-width: 1281px; max-width: 1500px; } }

Added patch phpcs-nested-followup.patch.

I couldn't use your patch directly because here was a typo in the indentation sniff (wrong var, minor thing), it didn't quite work with multiple classes in the nested area and I actually wanted to enforce spacing around the braces of a nesting class definition anyway. So I've updated the sniffs you identified and another as well. THe git repo has been updated. Relevant commits: https://github.com/squizlabs/PHP_CodeSniffer/commit/f09151959e8d0bdb93b50b8f1 04f1945a303213f https://github.com/squizlabs/PHP_CodeSniffer/commit/d18cd88150e8a80400bae36d2 12cb1795c612f8f Hopefully that fixes the problems with nested classes. Let me know if you find more and thanks for all your help so far.

Closing as I haven't got feedback about the latest change. If something isn't working, please reopen and let me know.