Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.0.0
Bug #19255 bug13332.phpt fails with PHP 5.4
Submitted: 2012-01-30 01:15 UTC
From: remicollet Assigned:
Status: Open Package: File_CSV (version 1.0.0)
PHP Version: 5.4 RC (specify # in Description) OS: GNU/Linux (Fedora 16)
Roadmaps: (Not assigned)    
Subscription  


Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know! Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem : 5 + 14 = ?

 
 [2012-01-30 01:15 UTC] remicollet (Remi Collet)
Description: ------------ Because of var_dump output changes, this test fails with php 5.4. $ cat ./CSV/bug13332.diff 002- [0]=> 002+ [0] => 004- [0]=> 004+ [0] => ... I think, a switch to a simple print_r could be a good solution. Please, see attached patch

Comments

 [2012-01-30 01:16 UTC] remicollet (Remi Collet)
Added patch bug13332.patch.
 [2012-01-30 04:18 UTC] doconnor (Daniel O'Connor)
LGTM at first glance. That said, it's probably better to make an expected/equals array and assert equivalence - ie PHPUnit's assertSame/assertEquals.
 [2012-01-30 04:22 UTC] doconnor (Daniel O'Connor)
Odd http://test.pear.php.net:8080/job/File/ shows tests/Util/sortFiles.phpt breaking in build 6/7 - about when we upgraded to the PHP 5.4 RC. It doesn't seem to show the CSV bug happening.