| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 1.5.0 |
| Bug #190 | tons of notices in Crypt_CHAP | ||
|---|---|---|---|
| Submitted: | 2003-11-04 14:11 UTC | ||
| From: | mike | Assigned: | mbretter |
| Status: | Closed | Package: | Crypt_CHAP |
| PHP Version: | Irrelevant | OS: | |
| Roadmaps: | (Not assigned) | ||
[2003-11-04 14:11 UTC] mike
Description:
------------
Crypt/CHAP.php and Crypt/CHAP_DES.php are throwing tons of Notices.
The following patch would eliminate this:
--- CHAP.php 2003-09-19 17:07:47.140625000 +0200
+++ CHAP.new.php 2003-11-04 15:07:38.640625000 +0100
@@ -197,6 +197,7 @@
*/
function str2unicode($str)
{
+ $uni = '';
for ($i = 0; $i < strlen($str); $i++) {
$a = ord($str{$i}) << 8;
$uni .= sprintf("%X", $a);
--- CHAP_DES.php 2003-09-19 17:07:47.140625000 +0200
+++ CHAP_DES.new.php 2003-11-04 15:05:09.093750000 +0100
@@ -48,6 +48,7 @@
$blockCount++; //Add another block for them
$clearText = str_pad($clearText, $blockCount * 8, chr(0x00)); //Pad it out with zeroes
}
+ $cypherText = '';
for ($i = 0; $i < $blockCount; $i++) { //Cycle through the blocks
$clearBlock = substr($clearText, $i * 8, 8); //Grab a block from the input
$cypherBlock = des_block_encode(des_bits_to_bytes ($clearBlock), $keys); //Encrypt it
@@ -76,6 +77,7 @@
34, 2, 42, 10, 50, 18, 58, 26,
33, 1, 41, 9, 49, 17, 57, 25);
+ $ip = '';
foreach ($ip_table as $bit) {
$ip .= $clearText[$bit - 1];
}
@@ -86,6 +88,7 @@
$r[$index] = des_xor($l[$index - 1], des_transform($r[$index - 1], $subKeys[$index]));
}
+ $cypherBlock = '';
foreach ($ip1_table as $bit) {
$concat = $r[16] . $l[16];
$cypherBlock .= $concat[$bit - 1];
@@ -117,6 +120,7 @@
2, 2, 2, 2,
1, 2, 2, 2,
2, 2, 2, 1);
+ $k = '';
foreach ($pc1 as $bit) {
$k .= $key[$bit - 1];
}
@@ -132,7 +136,7 @@
for ($i = 1; $i <= 16; $i++) {
foreach ($pc2 as $bit) {
$concat = $c[$i] . $d[$i];
- $k[$i] .= $concat[$bit - 1];
+ @$k[$i] .= $concat[$bit - 1];
}
}
return ($k);
@@ -200,9 +204,11 @@
chr(0x01).chr(0x01).chr(0x00).chr(0x00), chr(0x01).chr(0x01).chr(0x00).chr(0x01),
chr(0x01).chr(0x01).chr(0x01).chr(0x00), chr(0x01).chr(0x01).chr(0x01).chr(0x01));
+ $e = '';
foreach ($e_table as $bit) {
$e .= $data[$bit - 1];
}
+ $sResult = '';
$ek = des_xor($e, $key);
for ($i = 0; $i < 8; $i++) {
$offset = $i * 6;
@@ -214,6 +220,7 @@
ord($ek[$offset + 5]) * 0x10;
$sResult .= $nybbles[$s[$i][$sAddress]];
}
+ $p = '';
foreach ($p_table as $bit) {
$p .= $sResult[$bit - 1];
}
@@ -222,6 +229,7 @@
function des_bits_to_bytes($bitStream)
{
+ $byteStream = '';
for ($i = 0; $i < strlen($bitStream); $i++) {
$val = ord($bitStream[$i]);
if ($val & 0x80) {$byteStream .= chr(0x01);} else {$byteStream .= chr(0x00);}
@@ -238,6 +246,7 @@
function des_bytes_to_bits($byteStream)
{
+ $bitStream = '';
for ($i = 0; $i < (strlen($byteStream) / 8); $i++) {
$offset = $i * 8;
$value = ord($byteStream[$offset]) * 0x80 +
@@ -260,6 +269,7 @@
function des_xor($a, $b)
{
+ $xor = '';
for ($i = 0; $i < strlen($a); $i++) {
$xor .= $a[$i] ^ $b[$i];
}
@@ -289,11 +299,13 @@
224,224,227,227,229,229,230,230,233,233,234,234,236,236,239,239,
241,241,242,242,244,244,247,247,248,248,251,251,253,253,254,254);
+ $bin = '';
for ($i = 0; $i < strlen($key); $i++) {
$bin .= sprintf('%08s', decbin(ord($key{$i})));
}
$str1 = explode('-', substr(chunk_split($bin, 7, '-'), 0, -1));
+ $x = '';
foreach($str1 as $s) {
$x .= sprintf('%02s', dechex($odd_parity[bindec($s . '0')]));
}