Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.4.2
Request #18562 hash table support
Submitted: 2011-05-25 17:52 UTC
From: elbandi Assigned: elbandi
Status: Closed Package: File_Gettext (version 0.4.1)
PHP Version: 5.3.1 OS: linux
Roadmaps: (Not assigned)    
Subscription  


Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know! Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem : 4 + 35 = ?

 
 [2011-05-25 17:52 UTC] elbandi (Elso Andras)
Description: ------------ I added the hash table support when createing MO file.

Comments

 [2011-05-25 17:54 UTC] elbandi (Elso Andras)
Added patch hashtable-support.patch.
 [2012-01-02 07:22 UTC] doconnor (Daniel O'Connor)
-Status: Open +Status: Feedback
clockwerx@clockwerx-desktop:~/pear-svn-git/File_Gettext$ patch -p1 < patch- download.php\?id\=18562\&patch\=hashtable- support.patch\&revision\=1306331662 can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |diff --git a/File_Gettext-0.4.1/Gettext/MO.php b/File_Gettext- 0.4.1/Gettext/MO.php |index 521b489..a84a305 100644 |--- a/File_Gettext-0.4.1/Gettext/MO.php |+++ b/File_Gettext-0.4.1/Gettext/MO.php -------------------------- File to patch: Gettext/MO.php patching file Gettext/MO.php Hunk #1 FAILED at 233. Hunk #2 FAILED at 270. Hunk #3 FAILED at 279. Hunk #4 FAILED at 296. Hunk #5 succeeded at 332 (offset 20 lines). 4 out of 5 hunks FAILED -- saving rejects to file Gettext/MO.php.rej This code is now living on github, so maybe sending in pull request might be easier.
 [2012-01-02 16:33 UTC] elbandi (Elso Andras)
I sent a pull request: https://github.com/pear/File_Gettext/pull/1 Elbandi
 [2012-01-05 03:51 UTC] gauthierm (Michael Gauthier)
Can you run phpcs on your patch to ensure it conform to the PEAR coding standards? Also add docblocks and inline comments for the new methods. I have no idea what they do from a cursory glance. I also recommend more descriptive variable and method names. What does _hashpjw() mean? What is $g?
 [2012-01-05 17:09 UTC] elbandi (Elso Andras)
The all changes come from official GetText. The hash function: http://goo.gl/o2VQO The prime functions: http://goo.gl/Cs1DR And the inserted lines to "save" method: http://goo.gl/Eqru1 I added the coding style fix patch to pull request.
 [2012-01-29 05:44 UTC] doconnor (Daniel O'Connor)
Darned google just shut down all of the codesearch links. We'll take your work from it that these are ported correctly.
 [2012-01-29 05:45 UTC] doconnor (Daniel O'Connor)
-Status: Feedback +Status: Closed -Assigned To: +Assigned To: elbandi
This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.
 [2012-05-14 16:07 UTC] lambik (Tom Mmmmmm)
Just filed a bug report related to this at https://pear.php.net/bugs/bug.php?id=19419 Not terribly happy with the codesearch shutdown, since I cannot attempt to fix the bug myself now..