Description: ------------ Running code sniffer with a a custom ruleset.xml file fails to register anything in the standard's Sniffs directory. Looking at the code for setTokenListeners, this is due to setting the standardsDir property to the ruleset file rather than its parent directory. See attached diff for a one-liner fix. Test script: --------------- Create a custom standard using the tutorial at: http://pear.php.net/manual/en/package.php.php-codesniffer.coding-standard-tutorial.php Then test with: phpcs -v --standard=/path/to/MyStandard/ruleset.xml test.php Expected result: ---------------- Registering sniffs in MyStandard standard... DONE (1 sniffs registered) Processing test.php [71 tokens in 15 lines]... DONE in < 1 second (0 errors, 0 warnings) FILE: test.php -------------------------------------------------------------------------------- FOUND 3 ERROR(S) AFFECTING 3 LINE(S) -------------------------------------------------------------------------------- 3 | ERROR | Hash comments are prohibited; found # Check for valid contents. 7 | ERROR | Hash comments are prohibited; found # Value needs to be an array. 9 | ERROR | Hash comments are prohibited; found # Error. -------------------------------------------------------------------------------- Actual result: -------------- Registering sniffs in MyStandard standard... DONE (0 sniffs registered) Processing test.php [71 tokens in 15 lines]... DONE in < 1 second (0 errors, 0 warnings)

Added patch Fix.

This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. Thanks for the patch.

Turns out that this patch causes bug #18200

New patch only applies dirname is the ruleset's filename is ruleset.xml