Description: ------------ When tokenising an array construct whose parameters are references, the isReference function in File.php incorrectly returns false. Test script: --------------- <?php error_reporting(0); require_once('PHP/CodeSniffer.php'); $file = new PHP_CodeSniffer_File(); $file->start( '<?php $a = "a"; $b = array(&$a); echo $a; $b[0] = "A"; echo $a; ?>' ); echo 'Looking at tokens 14 and 15: ' . $file->getTokensAsString(14, 2) . "\n"; echo 'Is token 14 a reference? ' . ($file->isReference(14) ? 'Yes' : 'No') . "\n"; ?> Expected result: ---------------- Expected isReference to return true for the token that is the ampersand before the $a variable on line 9. Actual result: -------------- At the moment, it returns false. This can be resolved by changing line 2147 (in v1.2.2) from: if ($owner['code'] === T_FUNCTION) { to: if (in_array($owner['code'], array(T_FUNCTION, T_ARRAY), true)) {

This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.