Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.2.1
Bug #17721 Use preg_match instead of deprecated functions
Submitted: 2010-08-17 18:39 UTC
From: olleolleolle Assigned: olleolleolle
Status: Closed Package: DB_ldap (version SVN)
PHP Version: 5.3.1 OS:
Roadmaps: (Not assigned)    
Subscription  


Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know! Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem : 4 + 24 = ?

 
 [2010-08-17 18:39 UTC] olleolleolle (Olle Jonsson)
Description: ------------ DB_ldap_use_preg_match.patch

Comments

 [2010-08-17 18:39 UTC] olleolleolle (Olle Jonsson)
Added patch DB_ldap_use_preg_match.patch.
 [2010-08-21 04:01 UTC] doconnor (Daniel O'Connor)
I don't suppose you know if there is good test coverage for getSequence()?
 [2010-08-21 04:16 UTC] olleolleolle (Olle Jonsson)
From what I can see this package has 0 tests. The package is unmaintained, but not abandoned.
 [2010-08-22 04:41 UTC] olleolleolle (Olle Jonsson)
Added patch DB_ldap_use_explode.patch.
 [2010-08-22 04:42 UTC] olleolleolle (Olle Jonsson)
Added patch a_test_suite.patch.
 [2010-08-22 04:44 UTC] olleolleolle (Olle Jonsson)
Now that PHPUnit exists, and its mocking facility's so good, I put it to use, and covered the ereg-change I was doing. As I fiddled with it, trying to reduce it a little, I came to the conclusion that I could get away from the regex at all, and found a way to use explode() instead.
 [2010-08-23 15:14 UTC] doconnor (Daniel O'Connor)
-Status: Open +Status: Closed -Assigned To: +Assigned To: olleolleolle
This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.