| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 0.1.3 |
| Bug #16338 | "no localized title could be found" occur with ja_JP.xml | ||
|---|---|---|---|
| Submitted: | 2009-06-18 08:06 UTC | ||
| From: | hshimooka | Assigned: | hshimooka |
| Status: | Closed | Package: | Date_Holidays_Japan (version 0.1.1) |
| PHP Version: | 5.2.9 | OS: | CentOS5.2 |
| Roadmaps: | (Not assigned) | ||
[2009-06-18 08:06 UTC] hshimooka
(Hideyuki Shimooka)
Description:
------------
If with ja_JP.xml, a following error occur in 1973, 1979, 1984 .
"The internal name (substituteHolidayForshowaEmperorsBirthday) for the holiday was correct but no localized title could be found"
Test script:
---------------
<?php
/**
* @see http://d.hatena.ne.jp/shimooka/20080827/1219818457#c1245205759
*/
require_once 'Date/Holidays.php';
$filename = '/path/to/data/Date_Holidays_Japan/lang/Japan/ja_JP.xml';
for ($year = 1900; $year < date('Y'); $year++) {
$dh = Date_Holidays::factory('Japan', $year, 'ja_JP');
$dh->addTranslationFile($filename, 'ja_JP');
$holidays = array();
foreach ($dh->getHolidays() as $h) {
if (PEAR::isError($h)) {
echo $h->getMessage() . " in {$year}\n";
continue;
}
$holidays[$h->getDate()->format('%Y-%m-%d')] = $h->getTitle();
}
}
Expected result:
----------------
no error
Actual result:
--------------
$ php date_holidays_japan.php
The internal name (substituteHolidayForshowaEmperorsBirthday) for the holiday was correct but no localized title could be found in 1973
The internal name (substituteHolidayForshowaEmperorsBirthday) for the holiday was correct but no localized title could be found in 1979
The internal name (substituteHolidayForshowaEmperorsBirthday) for the holiday was correct but no localized title could be found in 1984
$
Comments
[2009-06-18 08:07 UTC] hshimooka
(Hideyuki Shimooka)
The following patch has been added/updated:
Patch Name: ja_JP.xml.txt
Revision: 1245294420
URL: http://pear.php.net/bugs/patch-display.php?bug=16338&patch=ja_JP.xml.txt&revision=1245294420&display=1
[2009-06-18 08:37 UTC] hshimooka
(Hideyuki Shimooka)
I archived ja_JP.xml and ja_JP.ser into lang.tar.gz .
You can download from http://www.doyouphp.jp/lang.tar.gz .
Or ... Can I still commit to pear repository?
[2009-06-19 05:31 UTC] doconnor
(Daniel O'Connor)
If you can't and you should be able to, send an email to pear-group
[2009-06-19 07:41 UTC] hshimooka
(Hideyuki Shimooka)
-Status: Open
+Status: Assigned
-Assigned To:
+Assigned To: hshimooka
thanks doconnor.
It seems I have a karma.
I will commit soon. [2009-06-19 08:01 UTC] hshimooka
(Hideyuki Shimooka)
-Status: Assigned
+Status: Closed
This bug has been fixed in CVS.
If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET).
If this was a problem with the pear.php.net website, the change should be live shortly.
Otherwise, the fix will appear in the package's next release.
Thank you for the report and for helping us make PEAR better.