Description: ------------ If you match a URL that contains a query string, then supply additional parameters when attempting to generate a new URL, the generator doesn't take into account the existing parameters and so incorrectly adds a '?' where an '&' is required. For example, match: connect('search/notice?q=:q', array('action' => 'noticesearch'),array('q' => '.+')); Then pass the following into generate(): $args - ( [action] => noticesearch, [q] => x) $params - ([p] => 1 ) Instead of getting back "/search/notice?q=x&p=1" you get the invalid "/search/notice?q=x?p=1". Test script: --------------- This fixes it... --- a/extlib/Net/URL/Mapper/Path.php +++ b/extlib/Net/URL/Mapper/Path.php @@ -241,7 +241,12 @@ class Net_URL_Mapper_Path } $path = '/'.trim(Net_URL::resolvePath($path), '/'); if (!empty($qstring)) { - $path .= '?'.http_build_query($qstring); + if (!strpos($path, '?')) { + $path .= '?'; + } else { + $path .= '&'; + } + $path .= http_build_query($qstring); } if (!empty($anchor)) { $path .= '#'.ltrim($anchor, '#');

This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better.