| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 1.5.0a1 |
| Bug #10871 | Wrong rendering of inline {@internal}} | ||
|---|---|---|---|
| Submitted: | 2007-04-28 11:54 UTC | ||
| From: | cwiedmann | Assigned: | ashnazg |
| Status: | Closed | Package: | PhpDocumentor (version 1.4.0a1) |
| PHP Version: | 5.2.1 | OS: | Windows_NT |
| Roadmaps: | 1.4.0a2 | ||
[2007-04-28 11:54 UTC] cwiedmann
(Carsten Wiedmann)
Description:
------------
The renderer removes the last char from the text and writes a "}" instead.
Test script:
---------------
/**
* test_method()
*
* {@internal Method name is not in camel caps format}}
*/
Expected result:
----------------
<p class="short-description">test_method()</p>
<p class="description"><p>Method name is not in camel caps format</p></p>
Actual result:
--------------
<p class="short-description">test_method()</p>
<p class="description"><p>Method name is not in camel caps forma}</p></p>
Comments
[2007-04-30 17:15 UTC] ashnazg
(Chuck Burgess)
I can duplicate this on v1.4.0a1. Looks like the @internal handling code that strips off the final "}}" markers is one characters off, stripping "t}" from "format}}" rather than the "}}".
[2007-04-30 17:31 UTC] ashnazg
(Chuck Burgess)
Tested this in v1.3.2, 1.3.1, 1.3.0, and bug exists there also.
[2007-05-02 18:42 UTC] ashnazg
(Chuck Burgess)
Built unit tests for the phpDocumentorTParser->getInlineTags() method, which helped me demonstrate and then work to correct this bug. Attached the patch for phpDocumentorTParser.inc file to this bug.
Can't attach the unit test file here though, since it's not a DIFF file and it's >10k in size. I'm going to add it directly to CVS.
Patch is ready for Josh/Greg review.
[2007-05-02 20:00 UTC] jeichorn
(Joshua Eichorn)
Fix looks good, commit away, glad to hear you added unit tests