Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.2.3
Request #7754 ignorant urlEncode
Submitted: 2006-05-29 18:16 UTC
From: nils at phoque dot de Assigned:
Status: Open Package: Text_Wiki (version 1.1.0)
PHP Version: Irrelevant OS: Windows
Roadmaps: (Not assigned)    
Subscription  
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes. If this is not your bug, you can add a comment by following this link. If this is your bug, but you forgot your password, you can retrieve your password here.
Password:
Status:
2006-06-16 16:29 UTC
Package:
Bug Type:
Summary:
From: nils at phoque dot de
New email:
PHP Version: Package Version: OS:

 

 [2006-05-29 18:16 UTC] nils at phoque dot de (Nils Werner)
Description: ------------ urlEncode does a rawurlencode even if in some situations some special characters (i.e. a slash) shouldn't be encoded. Some option to "enable subpages" or a urlEncode-whitelist would be nice to fix this. Test script: --------------- not really necessary Expected result: ---------------- <a href="page/subpage">subpage</a> Actual result: -------------- <a href="page%2Fsubpage">subpage</a>

Comments

 [2006-05-29 20:06 UTC] User who submitted this comment has not confirmed identity
If you submitted this note, check your email.If you do not have a message, click here to re-send
MANUAL CONFIRMATION IS NOT POSSIBLE.  Write a message to pear-dev@lists.php.net
to request the confirmation link.  All bugs/comments/patches associated with this

email address will be deleted within 48 hours if the account request is not confirmed!
 [2006-05-31 11:04 UTC] nils at phoque dot de
It doesn't concearn Text_Wiki but Text_Wiki_Mediawiki wich uses Text_Wiki's urlEncode: <?php require_once 'Text/Wiki/Mediawiki.php'; $wiki = new Text_Wiki_Mediawiki; $wiki->setRenderConf('xhtml', 'wikilink', 'pages', false); $wiki->setRenderConf('xhtml', 'wikilink', 'view_url', '/%s/'); echo $wiki->transform("[[page/subpage|Subpage]]"); ?>
 [2006-05-31 12:01 UTC] ritzmo at php dot net (Moritz Venn)
Actually it's not Text_Wiki_Mediawiki, which uses urlEncode but Text_Wiki. The problem occuring is that there is no Class for Subpage-Links, so the used class is - correclty - still Wikilink. So urlEncode happens in the Xhtml-Renderer and not in Mediawiki-Wikilink. This problem obviously only occurs in the Mediawiki-Parser, as its the only one accepting Subpages. So the question is if its better to remove the support of sub-pages in mediawiki or if its more logical to extend the Renderer.
 [2006-06-14 10:39 UTC] nils at phoque dot de
Since Mediawiki itself accepts subpages (Wikipedia does only in the User:-namespace), I think it makes perfectly sense to enable Text_Wiki_Mediawiki to have subpages as well.
 [2006-06-16 16:29 UTC] ritzmo at php dot net (Moritz Venn)
Although I risk to repeat myself... The discussion is not actually of enabling a feature in Text_Wiki_Mediawiki, but in Text_Wiki. So I'm reassigning this to Text_Wiki as I heard nothing from the devs about this issue and I'm not willing to remove support in Text_Wiki_Mediawiki without response.
 [2007-03-27 09:14 UTC] User who submitted this comment has not confirmed identity
If you submitted this note, check your email.If you do not have a message, click here to re-send
MANUAL CONFIRMATION IS NOT POSSIBLE.  Write a message to pear-dev@lists.php.net
to request the confirmation link.  All bugs/comments/patches associated with this

email address will be deleted within 48 hours if the account request is not confirmed!