Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.2.5

Bug #3953 HTML_Common::_updateAttrArray() does not return array
Submitted: 2005-03-24 23:18 UTC
From: herojoker at nexgo dot de Assigned: thesaur
Status: Closed Package: HTML_Common
PHP Version: Irrelevant OS: Irrelevant
Roadmaps: (Not assigned)    
Subscription  


 [2005-03-24 23:18 UTC] herojoker at nexgo dot de
Description: ------------ Hello! As described in the summary HTML_Common::_updateAttrArray() does not return the updated array. Since it works with the reference and you don't use the return value (which would be null), you should update the docs (remove @return array). Furthermore you should documentate that it returns false when $attr2 is not an array. (Eventually you should make use of that in your code) Hero Wanders

Comments

 [2005-03-24 23:25 UTC] thesaur
Thanks for the hint, but _updateAttrArray is a private method. It is not intended for external use, even though some PEAR classes may make use of it. Expect things to be different in HTML_Common2.
 [2005-03-24 23:43 UTC] herojoker at nexgo dot de
I knew that. I just wanted to assure code quality. Hero Wanders
 [2005-03-24 23:54 UTC] thesaur
OK, we'll fix the docs and make sure it meets the high standards we've set out to achieve :)
 [2005-09-01 10:51 UTC] thesaur
This has been fixed in the 1.2.2 release. Thank you for helping make PEAR better.