| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 1.2.2 |
| Bug #2512 | When using a custom valueColumn no pref ever returned | ||
|---|---|---|---|
| Submitted: | 2004-10-12 07:42 UTC | ||
| From: | aashley at optimiser dot com | Assigned: | jellybob |
| Status: | Closed | Package: | Auth_PrefManager |
| PHP Version: | 5.0.2 | OS: | All |
| Roadmaps: | (Not assigned) | ||
[2004-10-12 07:42 UTC] aashley at optimiser dot com
Description:
------------
When using a custom valueColumn the valueColumn string is stored in a form quoted for using in SQL statements.
This makes it impossible for line 209 to retrieve the value from the returned array.
My patch to fix this stores the valueColumn as the original valueColumn (Auth_PrefManager::_valueColumn) and the quoted valueColumn (Auth_PrefManager::_valueColumnQuote). I chose to do it this way to minimise the number of function calls needed for setting and deleting preferences.
This could just as easily be done to store only the original version and quote it as needed.
Patch is available at: http://frood.cernun.net/stuff/PrefManager-custom-valueColumn.patch
Comments
[2004-11-07 20:15 UTC] jellybob at gmail dot com
Thank you for the patch, I'll apply it to CVS sometime soon and then make a new relase.
[2005-04-04 23:59 UTC] User who submitted this comment has not confirmed identity
If you submitted this note, check your email.If you do not have a message, click here to re-send MANUAL CONFIRMATION IS NOT POSSIBLE. Write a message to pear-dev@lists.php.net to request the confirmation link. All bugs/comments/patches associated with this email address will be deleted within 48 hours if the account request is not confirmed!