| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 0.1.3 |
| Bug #20451 | new holiday 'mountain day' is not covered yet. | ||
|---|---|---|---|
| Submitted: | 2014-11-28 17:13 UTC | ||
| From: | sasezaki | Assigned: | kguest |
| Status: | Closed | Package: | Date_Holidays_Japan (version 0.1.2) |
| PHP Version: | Irrelevant | OS: | |
| Roadmaps: | (Not assigned) | ||
[2014-11-28 17:13 UTC] sasezaki
(Kazusuke Sasezaki)
Description:
------------
Along with Japanese Holiday enactment at 2014, August 11 should be judged
as Holiday.
ref. http://en.wikipedia.org/wiki/Mountain_Day
http://www.shugiin.go.jp/internet/itdb_annai.nsf/html/statics/housei/html/h-
shuhou186.html (The House of Representatives of Japan Information)
Test script:
---------------
$japan = Date_Holidays::factory('Japan');
var_dump($obj->isHoliday('2016-08-11'));
Expected result:
----------------
bool(true)
Actual result:
--------------
bool(false)
Comments
[2014-11-28 17:20 UTC] sasezaki
(Kazusuke Sasezaki)
-Summary: new holiday 'mountain day'(???) is not covered yet.
+Summary: new holiday 'mountain day' is not covered yet.
[2014-11-28 17:26 UTC] sasezaki
(Kazusuke Sasezaki)
I made a patch & pull request at github.
https://github.com/pear/Date_Holidays/pull/5
[2015-08-20 03:54 UTC] kguest
(Ken Guest)
-Status: Assigned
+Status: Closed
This bug has been fixed in SVN.
If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET).
If this was a problem with the pear.php.net website, the change should be live shortly.
Otherwise, the fix will appear in the package's next release.
Thank you for the report and for helping us make PEAR better.
I've merged this in and will upload a new release soon.