Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.2.2

Bug #19177 TONS of test failures
Submitted: 2012-01-01 20:02 UTC
From: danielc Assigned: doconnor
Status: Closed Package: Date_Holidays_Australia (version SVN)
PHP Version: 5_4 SVN-2012-01-01 OS:
Roadmaps: (Not assigned)    
Subscription  


 [2012-01-01 20:02 UTC] danielc (Daniel Convissor)
Description: ------------ The Australia package has an astounding number of test failures (something like 60) http://test.pear.php.net:8080/job/Date_Holidays/13/testReport/

Comments

 [2012-01-03 04:34 UTC] doconnor (Daniel O'Connor)
So... a number of these are simply holidays which are not yet implemented properly. IE: 28) Date_Holidays_Driver_AustraliaSA_TestSuite::testHolidays with data set #10 ('proclamationDay', 2013, array(26, 12, 2013)) Invalid internal name: proclamationDay ... the driver doesn't yet implement it.
 [2012-01-03 06:30 UTC] danielc (Daniel Convissor)
Then the Date_Holidays_Driver_Australia* test scripts need to put in calls to "$this->markTestIncomplete()" where appropriate.
 [2012-01-04 18:54 UTC] doconnor (Daniel O'Connor)
Somewhat improved at the moment. I'm not too inclined to markTestSkipped / Incomplete on these, as the tests are actually done - but the code isn't right. Will keep plugging away.
 [2012-01-04 20:18 UTC] doconnor (Daniel O'Connor)
-Status: Open +Status: Closed -Assigned To: +Assigned To: doconnor
This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. AU related tests only fixed in SVN.