Description: ------------ As per http://comments.gmane.org/gmane.comp.php.pear.qa/4356

Here is a patch: Index: Net/DNSBL.php ===================================================== ============== --- Net/DNSBL.php (revision 317868) +++ Net/DNSBL.php (working copy) @@ -27,11 +27,11 @@ * @license http://www.php.net/license/3_01.txt PHP License 3.01 * @version CVS: $Id$ * @link http://pear.php.net/package/Net_DNSBL - * @see Net_DNS + * @see Net_DNS2 * @since File available since Release 1.0.0 */ -require_once 'Net/DNS.php'; +require_once 'Net/DNS2.php'; /** * PEAR::Net_DNSBL @@ -216,14 +216,18 @@ public function isListed($host, $checkall = false) { $isListed = false; - $resolver = new Net_DNS_Resolver; + $resolver = new Net_DNS2_Resolver; if (!is_string($host)) { return false; } foreach ($this->blacklists as $blacklist) { - $response = $resolver->query($this->getHostForLookup($host, $blacklist)); + try { + $response = $resolver->query($this->getHostForLookup($host, $blacklist)); + } catch (Net_DNS2_Exception $e) { + $response = false; + } if ($response) { $isListed = true; if ($checkall) { @@ -285,9 +289,9 @@ { // Currently only works for v4 addresses. if (filter_var($host, FILTER_VALIDATE_IP)) { - $ip = $host; - } else { - $resolver = new Net_DNS_Resolver; + $ip = $host; + } else { + $resolver = new Net_DNS2_Resolver; $response = $resolver->query($host); $ip = isset($response->answer[0]->address)?$response->answer[0]- >address:NULL; } However, one of the Unit tests is failing. There seems a problem in TXT record handling of Net_DNS2, could you please take a look, Daniel?

I'll have a shot at this; and implementing a reset() method for Services_Trackback - http://test.pear.php.net:8080/job/Services_Trackback/lastCompletedBuild/testReport /(root)/Services_Trackback_SpamCheck_DNSBL_Test/test_reset/

Applying the changes breaks lots of tests now :(

Added patch netdns2_update.

I added a patch file that updates Net_DNSBL to use Net_DNS2; it's pretty straight forward- I tested all your examples and they all worked fine after the patch. The errors you were getting likely where from the exceptions not being caught. Mike

Is there any timeline on when/if this patch will be applied? I'm already using the Net_DNS2 package, and I don't really want to install the Net_DNS package- especially since it's deprecated now. Thanks- John

File to patch: Net/DNSBL.php patching file Net/DNSBL.php Hunk #1 FAILED at 27. Hunk #2 succeeded at 216 (offset -1 lines). Hunk #3 succeeded at 240 (offset -1 lines). Hunk #4 succeeded at 263 (offset -1 lines). Hunk #5 FAILED at 304. 2 out of 5 hunks FAILED -- saving rejects to file Net/DNSBL.php.rej

Added patch net_dns2.

All tests passing - the SURBL url appears dead, so I've pointed it at the waybackmachine

Tests still fail: test_unit: [exec] PHPUnit 3.5.5 by Sebastian Bergmann. [exec] [exec] ...................E [exec] [exec] Time: 50 seconds, Memory: 11.50Mb [exec] [exec] There was 1 error: [exec] [exec] 1) NetDNSBLSURBLTest::testInvalidArguments [exec] InvalidArgumentException: empty query string provided [exec] [exec] /usr/share/php/Net/DNS2/Packet/Request.php:116 [exec] /usr/share/php/Net/DNS2/Packet/Request.php:80 [exec] /usr/share/php/Net/DNS2/Resolver.php:118 [exec] /home/project/pear/Net_DNSBL/trunk/Net/DNSBL.php:231 [exec] /home/project/pear/Net_DNSBL/trunk/tests/NetDNSBLSURBLTest.php:158 [exec] [exec] FAILURES! [exec] Tests: 20, Assertions: 93, Errors: 1. [exec] [exec] Writing code coverage data to XML file, this may take a moment. [exec] [exec] Generating code coverage report, this may take a moment.

@Sebastian - is that with the patch applied? http://test.pear.php.net:8080/job/Net_DNSBL/33/console vs http://test.pear.php.net:8080/job/Net_DNSBL/32/console shows that test unfortunately failing; but not in the way you describe?

It's without the patch. On my local machine the tests pass without the patch applied.