Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 0.4.0

Bug #18292 S3 and Stream have a different option name.
Submitted: 2011-02-22 14:20 UTC
From: hiderer Assigned: gauthierm
Status: Closed Package: Services_Amazon_S3 (version 0.3.1)
PHP Version: Irrelevant OS: Irrelevant
Roadmaps: (Not assigned)    
Subscription  


 [2011-02-22 14:20 UTC] hiderer (Hidenobu Shinozuka)
Description: ------------ Http_option is defined "$httpConfig" at S3.php line 162, But in Stream.php specifying "httpOptions" or "http_options" at line 940 to 944. "httpConfig" unified hope. Test script: --------------- Services_Amazon_S3_Stream::register('s3', array( 'access_key_id' => $access_key, 'secret_access_key' => $secret_key, 'http_config' => array('proxy_host' => '172.24.xx.xx', 'proxy_port' => 8080) )); $streamS3 = fopen('s3://mybucket/mykey', 'w');

Comments

 [2011-03-27 20:07 UTC] till (Till Klampaeckel)
-Status: Open +Status: Bogus
Sorry, but your problem does not imply a bug in PEAR itself. For a list of more appropriate places to ask for help using PEAR, please visit http://pear.php.net/support/ as this bug system is not the appropriate forum for asking support questions. Thank you for your interest in PEAR. One is an option, one is a class variable. Class variables follow camelcase, as do class methods. All other config options use an underscore, I don't think this is inconsistent - it would be if it was otherwise. If we change one option, we'll have to change all. Add to this, this package is actually used in many places and despite the lower version number I'm against breaking BC.
 [2011-03-28 19:06 UTC] gauthierm (Michael Gauthier)
-Status: Bogus +Status: Assigned -Operating System: Centos 5.5 +Operating System: Irrelevant -PHP Version: 5.3.0 +PHP Version: Irrelevant
I looked over the code and the original reporter is correct. The variable name used in Stream.php is wrong. It's a bug, not a preference. As for the config name, I think we should continue to support 'http_option' for backwards-compatibility, but also add 'http_config' as the word 'config' is used throughout HTTP_Request2.
 [2011-03-28 19:07 UTC] gauthierm (Michael Gauthier)
-Assigned To: +Assigned To: gauthierm
 [2011-03-28 19:36 UTC] gauthierm (Michael Gauthier)
-Status: Assigned +Status: Closed
This bug has been fixed in SVN. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. Fixed in http://svn.php.net/viewvc?view=revision&revision=309787
 [2011-03-28 19:48 UTC] gauthierm (Michael Gauthier)
Release 0.3.2 contains a fix for this bug. Thanks for your report!