| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 2.4.2 |
| Bug #17728 | Patch: using pcre functions to avoid deprecation warnings | ||
|---|---|---|---|
| Submitted: | 2010-08-18 02:15 UTC | ||
| From: | olleolleolle | Assigned: | olleolleolle |
| Status: | Closed | Package: | HTML_Progress2 (version SVN) |
| PHP Version: | 5.3.1 | OS: | |
| Roadmaps: | (Not assigned) | ||
[2010-08-18 02:15 UTC] olleolleolle
(Olle Jonsson)
Description:
------------
The patch "using_pcre.patch" removes a usage of ereg_replace.
Comments
[2010-08-18 02:15 UTC] olleolleolle
(Olle Jonsson)
-Summary: Patch: using pcre functions
+Summary: Patch: using pcre functions to avoid deprecation
warnings
[2010-08-18 18:15 UTC] doconnor
(Daniel O'Connor)
I started with a plan to clean up this package and get the unit tests to run; so I could apply this patch.
Unfortunately; the best I can coax out of it is:
Tests: 89, Assertions: 30, Failures: 58, Errors: 2.
... and the code relies on weird uses of output buffering, static variables, recursion and the like - things which Shouldn't Be Done from a test driven development perspective; but have been for this package.
Also; it caused some really horrible performance regression when I ran tests that should never have worked - ie: fatal errors; before I "fixed" them.
Until I've got more comfort that I actually having a working package and I understand the code underneath...
[2010-09-03 16:17 UTC] doconnor
(Daniel O'Connor)
-Status: Assigned
+Status: Closed
-Assigned To: doconnor
+Assigned To: olleolleolle
This bug has been fixed in SVN.
If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET).
If this was a problem with the pear.php.net website, the change should be live shortly.
Otherwise, the fix will appear in the package's next release.
Thank you for the report and for helping us make PEAR better.