Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.1.2

Bug #15348 Don't escape colons in URLs of vcards
Submitted: 2008-12-18 19:10 UTC
From: erny1803 Assigned: till
Status: Closed Package: Contact_Vcard_Build (version 1.1.1)
PHP Version: 4.4.4 OS: Debian Etch
Roadmaps: (Not assigned)    
Subscription  


 [2008-12-18 19:10 UTC] erny1803 (Ernesto Revilla)
Description: ------------ In URLs colons are escaped. This is not correct. See also #2660

Comments

 [2008-12-20 09:33 UTC] doconnor (Daniel O'Connor)
Ernesto, can you make a small executable test case to prove this? IE: $a = 1; $b = 2; assert($a + b == 3); // I would expect this to work but it doesn't!
 [2009-01-12 16:21 UTC] smartin (Sixto Martín)
Url Type definition: http://tools.ietf.org/html/rfc2426#section-3.6.8 Here is the test case to prove that the build escape colons at urls and shouldnt . <?php // report all errors error_reporting(E_ALL); // include the class file require_once 'Contact_Vcard_Parse.php'; require_once 'Contact_Vcard_Build.php'; // instantiate a parser object $parse = new Contact_Vcard_Parse(); $vcard = new Contact_Vcard_Build(); $vcard_text = <<<EOVCARD BEGIN:VCARD VERSION:3.0 N:Frank Dawson FN:Frank Dawson URL:http://home.earthlink.net/~fdawson END:VCARD EOVCARD; // parse it $data = $parse->fromText($vcard_text, true); // build it $vcard->setFromArray($data[0]); // print builded vcard echo $vcard->fetch(); // compare echo assert($vcard->fetch() == $vcard_text); ?>
 [2009-06-30 21:53 UTC] till (Till Klampaeckel)
-Status: Analyzed +Status: Closed -Assigned To: +Assigned To: till
This bug has been fixed in CVS. If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET). If this was a problem with the pear.php.net website, the change should be live shortly. Otherwise, the fix will appear in the package's next release. Thank you for the report and for helping us make PEAR better. Hey guys, I added your test to CVS, aside from adding a PROFILE section, it seems to work as advertised. Maybe the bug was fixed in CVS already. I added your test anyway and gave you credit for it. Thanks, Till