Package home | Report new bug | New search | Development Roadmap Status: Open | Feedback | All | Closed Since Version 1.5.0a1

Request #10670 Don't Die on Empty Tag Descriptions
Submitted: 2007-04-09 14:41 UTC Modified: 2007-04-19 10:43 UTC
From: ashnazg Assigned: ashnazg
Status: Closed Package: PhpDocumentor (version 1.3.1)
PHP Version: Irrelevant OS: WinXP
Roadmaps: 1.4.0a1    
Subscription  


 [2007-04-09 14:41 UTC] ashnazg (Chuck Burgess)
Description: ------------ There are several instances of tags that, if used with no description text, act as fatal runtime errors that cause PhpDocumentor to exit. These conditions should instead be handled as informational errors that do not cause PhpDocumentor to exit. Test script: --------------- <?php /** * Page Directive for BugReport3.php * @package BugReports */ /** * at-global test $GLOBALS['baz'] * @global */ $GLOBALS['baz'] = new test; /** * at-property string $_bar the bar prop * @property * @package BugReports */ class dummy { private $_bar; /** * at-staticvar integer an int * @staticvar */ function function1($baz) { static $foo = 6; } /** * at-var string * @var */ var $variable = false; } ?> Expected result: ---------------- General Parsing Stage Reading file /home/ashnazg/BugReport4.php -- Parsing file ERROR in BugReport4.php on line 10: "@global" tag was used without any parameters, illegal ERROR in BugReport4.php on line 17: "@property" tag was used without any parameters, illegal WARNING in BugReport4.php on line 17: @property magic tag does not have name, illegal. Ignoring tag "@property " ERROR in BugReport4.php on line 26: "@staticvar" tag was used without any parameters, illegal ERROR in BugReport4.php on line 35: "@var" tag was used without any parameters, illegal done Converting From Abstract Parsed Data Actual result: -------------- General Parsing Stage Reading file /home/ashnazg/BugReport4.php -- Parsing file ERROR in BugReport4.php on line 45: "@var" tag was used without any parameters, illegal ERROR in BugReport4.php on line 45: "@var" tag was used without any parameters, illegal ashnazg$

Comments

 [2007-04-09 14:47 UTC] ashnazg (Chuck Burgess)
There were several tags set to throw the PDERROR_MALFORMED_TAG: - global - staticvar - param - return - var - property Looks like param and return had already been changed to just record errors rather than fatal errors (original addErrorDie calls were commented out), while the remaining tags were still set to call addErrorDie(). This patch sets all these tags to record errors rather than fatal errors.
 [2007-04-09 14:50 UTC] jeichorn (Joshua Eichorn)
This change looks good
 [2007-04-18 15:58 UTC] cellog (Greg Beaver)
good
 [2007-04-19 10:43 UTC] ashnazg (Chuck Burgess)
Committed to CVS.