Source for file OperatorBracketSniff.php
Documentation is available at OperatorBracketSniff.php
* Tests that all arithmetic operations are bracketed.
* @author Greg Sherwood <gsherwood@squiz.net>
* @copyright 2006-2015 Squiz Pty Ltd (ABN 77 084 670 600)
* @license https://github.com/squizlabs/PHP_CodeSniffer/blob/master/licence.txt BSD Licence
namespace PHP_CodeSniffer\Standards\Squiz\Sniffs\Formatting;
use PHP_CodeSniffer\Sniffs\Sniff;
use PHP_CodeSniffer\Files\File;
use PHP_CodeSniffer\Util\Tokens;
class OperatorBracketSniff implements Sniff
* A list of tokenizers this sniff supports.
public $supportedTokenizers = array (
* Returns an array of tokens this test wants to listen for.
public function register ()
return Tokens ::$operators;
* Processes this test, when one of its tokens is encountered.
* @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
* @param int $stackPtr The position of the current token in the
* stack passed in $tokens.
public function process (File $phpcsFile, $stackPtr)
$tokens = $phpcsFile->getTokens ();
if ($phpcsFile->tokenizerType === 'JS' && $tokens[$stackPtr]['code'] === T_PLUS ) {
// JavaScript uses the plus operator for string concatenation as well
// so we cannot accurately determine if it is a string concat or addition.
// If the & is a reference, then we don't want to check for brackets.
if ($tokens[$stackPtr]['code'] === T_BITWISE_AND && $phpcsFile->isReference ($stackPtr) === true ) {
// There is one instance where brackets aren't needed, which involves
// the minus sign being used to assign a negative number to a variable.
if ($tokens[$stackPtr]['code'] === T_MINUS) {
// Check to see if we are trying to return -n.
$prev = $phpcsFile->findPrevious (Tokens ::$emptyTokens, ($stackPtr - 1 ), null , true );
if ($tokens[$prev]['code'] === T_RETURN ) {
$number = $phpcsFile->findNext (T_WHITESPACE , ($stackPtr + 1 ), null , true );
if ($tokens[$number]['code'] === T_LNUMBER || $tokens[$number]['code'] === T_DNUMBER ) {
$previous = $phpcsFile->findPrevious (T_WHITESPACE , ($stackPtr - 1 ), null , true );
if ($previous !== false ) {
$isAssignment = in_array($tokens[$previous]['code'], Tokens ::$assignmentTokens);
$isEquality = in_array ($tokens[$previous]['code'], Tokens ::$equalityTokens);
$isComparison = in_array ($tokens[$previous]['code'], Tokens ::$comparisonTokens);
if ($isAssignment === true || $isEquality === true || $isComparison === true ) {
// This is a negative assignment or comparison.
// We need to check that the minus and the number are
if (($number - $stackPtr) !== 1 ) {
$error = 'No space allowed between minus sign and number';
$phpcsFile->addError ($error, $stackPtr, 'SpacingAfterMinus');
$previousToken = $phpcsFile->findPrevious (T_WHITESPACE , ($stackPtr - 1 ), null , true , null , true );
if ($previousToken !== false ) {
// A list of tokens that indicate that the token is not
// part of an arithmetic operation.
if (in_array($tokens[$previousToken]['code'], $invalidTokens) === true ) {
&& isset ($tokens[$stackPtr]['nested_parenthesis']) === true
$brackets = $tokens[$stackPtr]['nested_parenthesis'];
if (isset ($tokens[$lastBracket]['parenthesis_owner']) === true
&& $tokens[$tokens[$lastBracket]['parenthesis_owner']]['code'] === T_CATCH
// This is a pipe character inside a catch statement, so it is acting
// as an exception type seperator and not an arithmetic operation.
// Tokens that are allowed inside a bracketed operation.
$allowed += Tokens ::$operators;
if (isset ($tokens[$stackPtr]['nested_parenthesis']) === true ) {
$parenthesis = array_reverse($tokens[$stackPtr]['nested_parenthesis'], true );
foreach ($parenthesis as $bracket => $endBracket) {
$prevToken = $phpcsFile->findPrevious (T_WHITESPACE , ($bracket - 1 ), null , true );
$prevCode = $tokens[$prevToken]['code'];
if ($prevCode === T_ISSET ) {
// This operation is inside an isset() call, but has
// no bracket of it's own.
if ($prevCode === T_STRING || $prevCode === T_SWITCH ) {
// We allow simple operations to not be bracketed.
// For example, ceil($one / $two).
for ($prev = ($stackPtr - 1 ); $prev > $bracket; $prev-- ) {
if (in_array($tokens[$prev]['code'], $allowed) === true ) {
$prev = $tokens[$prev]['parenthesis_opener'];
if ($prev !== $bracket) {
for ($next = ($stackPtr + 1 ); $next < $endBracket; $next++ ) {
if (in_array($tokens[$next]['code'], $allowed) === true ) {
$next = $tokens[$next]['parenthesis_closer'];
if ($next !== $endBracket) {
if (in_array($prevCode, Tokens ::$scopeOpeners) === true ) {
// This operation is inside a control structure like FOREACH
// or IF, but has no bracket of it's own.
// The only control structure allowed to do this is SWITCH.
if ($prevCode !== T_SWITCH ) {
// These are two open parenthesis in a row. If the current
// one doesn't enclose the operator, go to the previous one.
if ($endBracket < $stackPtr) {
if ($lastBracket === false ) {
// It is not in a bracketed statement at all.
$this->addMissingBracketsError ($phpcsFile, $stackPtr);
} else if ($tokens[$lastBracket]['parenthesis_closer'] < $stackPtr) {
// There are a set of brackets in front of it that don't include it.
$this->addMissingBracketsError ($phpcsFile, $stackPtr);
// We are enclosed in a set of bracket, so the last thing to
// check is that we are not also enclosed in square brackets
// like this: ($array[$index + 1]), which is invalid.
$squareBracket = $phpcsFile->findPrevious ($brackets, ($stackPtr - 1 ), $lastBracket);
$closeSquareBracket = $phpcsFile->findNext ($brackets, ($stackPtr + 1 ));
$this->addMissingBracketsError ($phpcsFile, $stackPtr);
$lastAssignment = $phpcsFile->findPrevious (Tokens ::$assignmentTokens, $stackPtr, null , false , null , true );
if ($lastAssignment !== false && $lastAssignment > $lastBracket) {
$this->addMissingBracketsError ($phpcsFile, $stackPtr);
* Add and fix the missing brackets error.
* @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
* @param int $stackPtr The position of the current token in the
* stack passed in $tokens.
public function addMissingBracketsError ($phpcsFile, $stackPtr)
$error = 'Arithmetic operation must be bracketed';
$fix = $phpcsFile->addFixableError ($error, $stackPtr, 'MissingBrackets');
$tokens = $phpcsFile->getTokens ();
T_OBJECT_OPERATOR => true ,
// Find the first token in the expression.
for ($before = ($stackPtr - 1 ); $before > 0; $before-- ) {
// Special case for plus operators because we can't tell if they are used
// for addition or string contact. So assume string concat to be safe.
if ($phpcsFile->tokenizerType === 'JS' && $tokens[$before]['code'] === T_PLUS) {
if (isset (Tokens ::$emptyTokens[$tokens[$before]['code']]) === true
|| isset (Tokens ::$operators[$tokens[$before]['code']]) === true
|| isset (Tokens ::$castTokens[$tokens[$before]['code']]) === true
|| isset ($allowed[$tokens[$before]['code']]) === true
$before = $tokens[$before]['parenthesis_opener'];
$before = $tokens[$before]['bracket_opener'];
$before = $tokens[$before]['bracket_opener'];
$before = $phpcsFile->findNext (Tokens ::$emptyTokens, ($before + 1 ), null , true );
// Find the last token in the expression.
for ($after = ($stackPtr + 1 ); $after < $phpcsFile->numTokens; $after++ ) {
// Special case for plus operators because we can't tell if they are used
// for addition or string contact. So assume string concat to be safe.
if ($phpcsFile->tokenizerType === 'JS' && $tokens[$after]['code'] === T_PLUS) {
if (isset (Tokens ::$emptyTokens[$tokens[$after]['code']]) === true
|| isset (Tokens ::$operators[$tokens[$after]['code']]) === true
|| isset (Tokens ::$castTokens[$tokens[$after]['code']]) === true
|| isset ($allowed[$tokens[$after]['code']]) === true
$after = $tokens[$after]['parenthesis_closer'];
$after = $tokens[$after]['bracket_closer'];
$after = $tokens[$after]['bracket_closer'];
$after = $phpcsFile->findPrevious (Tokens ::$emptyTokens, ($after - 1 ), null , true );
// Can only fix this error if both tokens are available for fixing.
// Adding one bracket without the other will create parse errors.
$phpcsFile->fixer ->beginChangeset ();
$phpcsFile->fixer ->replaceToken ($before, '('. $tokens[$before]['content']);
$phpcsFile->fixer ->replaceToken ($after, $tokens[$after]['content']. ')');
$phpcsFile->fixer ->endChangeset ();
}//end addMissingBracketsError()
Documentation generated on Mon, 11 Mar 2019 15:27:40 -0400 by phpDocumentor 1.4.4. PEAR Logo Copyright © PHP Group 2004.
|