Source for file InlineControlStructureSniff.php
Documentation is available at InlineControlStructureSniff.php
* Verifies that inline control statements are not present.
* @author Greg Sherwood <gsherwood@squiz.net>
* @copyright 2006-2015 Squiz Pty Ltd (ABN 77 084 670 600)
* @license https://github.com/squizlabs/PHP_CodeSniffer/blob/master/licence.txt BSD Licence
namespace PHP_CodeSniffer\Standards\Generic\Sniffs\ControlStructures;
use PHP_CodeSniffer\Sniffs\Sniff;
use PHP_CodeSniffer\Files\File;
use PHP_CodeSniffer\Util\Tokens;
class InlineControlStructureSniff implements Sniff
* A list of tokenizers this sniff supports.
public $supportedTokenizers = array (
* If true, an error will be thrown; otherwise a warning.
* Returns an array of tokens this test wants to listen for.
public function register ()
* Processes this test, when one of its tokens is encountered.
* @param \PHP_CodeSniffer\Files\File $phpcsFile The file being scanned.
* @param int $stackPtr The position of the current token in the
* stack passed in $tokens.
public function process (File $phpcsFile, $stackPtr)
$tokens = $phpcsFile->getTokens ();
if (isset ($tokens[$stackPtr]['scope_opener']) === true ) {
$phpcsFile->recordMetric ($stackPtr, 'Control structure defined inline', 'no');
// Ignore the ELSE in ELSE IF. We'll process the IF part later.
if ($tokens[$stackPtr]['code'] === T_ELSE ) {
$next = $phpcsFile->findNext (T_WHITESPACE , ($stackPtr + 1 ), null , true );
if ($tokens[$next]['code'] === T_IF ) {
if ($tokens[$stackPtr]['code'] === T_WHILE ) {
// This could be from a DO WHILE, which doesn't have an opening brace.
$lastContent = $phpcsFile->findPrevious (Tokens ::$emptyTokens, ($stackPtr - 1 ), null , true );
$brace = $tokens[$lastContent];
if (isset ($brace['scope_condition']) === true ) {
$condition = $tokens[$brace['scope_condition']];
if ($condition['code'] === T_DO ) {
// In Javascript DO WHILE loops without curly braces are legal. This
// is only valid if a single statement is present between the DO and
// the WHILE. We can detect this by checking only a single semicolon
// is present between them.
if ($phpcsFile->tokenizerType === 'JS') {
$lastDo = $phpcsFile->findPrevious (T_DO , ($stackPtr - 1 ));
$lastSemicolon = $phpcsFile->findPrevious (T_SEMICOLON, ($stackPtr - 1 ));
if ($lastDo !== false && $lastSemicolon !== false && $lastDo < $lastSemicolon) {
$precedingSemicolon = $phpcsFile->findPrevious (T_SEMICOLON, ($lastSemicolon - 1 ));
if ($precedingSemicolon === false || $precedingSemicolon < $lastDo) {
// This is a control structure without an opening brace,
// so it is an inline statement.
if ($this->error === true ) {
$fix = $phpcsFile->addFixableError ('Inline control structures are not allowed', $stackPtr, 'NotAllowed');
$fix = $phpcsFile->addFixableWarning ('Inline control structures are discouraged', $stackPtr, 'Discouraged');
$phpcsFile->recordMetric ($stackPtr, 'Control structure defined inline', 'yes');
// Stop here if we are not fixing the error.
$phpcsFile->fixer ->beginChangeset ();
if (isset ($tokens[$stackPtr]['parenthesis_closer']) === true ) {
$closer = $tokens[$stackPtr]['parenthesis_closer'];
if ($tokens[($closer + 1 )]['code'] === T_WHITESPACE
$phpcsFile->fixer ->addContent ($closer, ' {');
$phpcsFile->fixer ->addContent ($closer, ' { ');
$fixableScopeOpeners = $this->register ();
for ($end = ($closer + 1 ); $end < $phpcsFile->numTokens; $end++ ) {
if ($tokens[$end]['code'] === T_CLOSE_TAG ) {
if (in_array($tokens[$end]['code'], $fixableScopeOpeners) === true
&& isset ($tokens[$end]['scope_opener']) === false
// The best way to fix nested inline scopes is middle-out.
// So skip this one. It will be detected and fixed on a future loop.
$phpcsFile->fixer ->rollbackChangeset ();
if (isset ($tokens[$end]['scope_opener']) === true ) {
$type = $tokens[$end]['code'];
$end = $tokens[$end]['scope_closer'];
if ($type === T_DO || $type === T_IF || $type === T_ELSEIF || $type === T_TRY ) {
$next = $phpcsFile->findNext (Tokens ::$emptyTokens, ($end + 1 ), null , true );
$nextType = $tokens[$next]['code'];
// Let additional conditions loop and find their ending.
&& ($nextType === T_ELSEIF
// Account for DO... WHILE conditions.
if ($type === T_DO && $nextType === T_WHILE ) {
// Account for TRY... CATCH statements.
if ($type === T_TRY && $nextType === T_CATCH ) {
$end = $tokens[$next]['scope_closer'];
if ($tokens[$end]['code'] !== T_END_HEREDOC
if (isset ($tokens[$end]['parenthesis_closer']) === true ) {
$end = $tokens[$end]['parenthesis_closer'];
if ($tokens[$end]['code'] !== T_WHITESPACE ) {
if ($end === $phpcsFile->numTokens ) {
$next = $phpcsFile->findNext (Tokens ::$emptyTokens, ($end + 1 ), null , true );
if ($next === false || $tokens[$next]['line'] !== $tokens[$end]['line']) {
// Looks for completely empty statements.
$next = $phpcsFile->findNext (T_WHITESPACE , ($closer + 1 ), ($end + 1 ), true );
// Account for a comment on the end of the line.
for ($endLine = $end; $endLine < $phpcsFile->numTokens; $endLine++ ) {
if (isset ($tokens[($endLine + 1 )]) === false
|| $tokens[$endLine]['line'] !== $tokens[($endLine + 1 )]['line']
if ($tokens[$endLine]['code'] !== T_COMMENT ) {
$addedContent = $phpcsFile->eolChar;
$phpcsFile->fixer ->addContent ($end, '; ');
$next = $phpcsFile->findNext (T_WHITESPACE , ($endToken + 1 ), null , true );
&& ($tokens[$next]['code'] === T_ELSE
|| $tokens[$next]['code'] === T_ELSEIF )
$phpcsFile->fixer ->addContentBefore ($next, '} ');
for ($first = $stackPtr; $first > 0; $first-- ) {
|| $tokens[($first - 1 )]['line'] !== $tokens[$first]['line']
if ($tokens[$first]['code'] === T_WHITESPACE ) {
$indent = $tokens[$first]['content'];
} else if ($tokens[$first]['code'] === T_INLINE_HTML
|| $tokens[$first]['code'] === T_OPEN_TAG
$addedContent .= $indent. '}';
if ($next !== false && $tokens[$endToken]['code'] === T_COMMENT ) {
$addedContent .= $phpcsFile->eolChar;
$phpcsFile->fixer ->addContent ($endToken, $addedContent);
$phpcsFile->fixer ->replaceToken ($end, '');
$phpcsFile->fixer ->addNewlineBefore ($endLine);
$phpcsFile->fixer ->addContent ($endLine, '}');
$phpcsFile->fixer ->replaceToken ($end, '}');
$phpcsFile->fixer ->endChangeset ();
Documentation generated on Mon, 11 Mar 2019 15:27:34 -0400 by phpDocumentor 1.4.4. PEAR Logo Copyright © PHP Group 2004.
|