Vote Details for "XML_GRDDL" by cweiske

» Details
Voter: Christian Weiske [Wishlist] Vote: +1 (not conditional) Reviews: Cursory source review
» Comment
- Please don't use absolute paths when loading drivers (factory()). PHP has include_path for good reasons: http://ucommbieber.unl.edu/peardoc/html/developers.recommendations.drivercheck.html - Instead of relying on @DATADIR@-replacements, you could (not have to) use PEAR_Config to retrieve the correct data directory (transform()) Clean code otherwise.