Vote Details for "Crypt_DiffieHellman" by saltybeagle

» Details
  • Voter: Brett Bieber [Wishlist]
  • Vote: +1 (not conditional)
  • Reviews: Deep source review, Run examples
» Comment
Excellent inline documentation... minor issues,

PHP Fatal error: Class 'Crypt_DiffieHellman_BigInteger' not found in /Users/bbieber/Desktop/Crypt_DiffieHellman-0.1.0a2/Crypt_DiffieHellman-0.1.0a2/DiffieHellman.php on line 380

Should be Crypt_DiffieHellman_Math_BigInteger

And on the tests -
1) testDiffieWithSpec(Crypt_DiffieHellmanTest)
Object of class Crypt_DiffieHellman could not be converted to string
/Users/bbieber/Desktop/Crypt_DiffieHellman-0.1.0a2/Crypt_DiffieHellman-0.1.0a2/tests/DiffieHellmanTest.php:34

I'm confident all will be cleared up, great work.