| Package home | Report new bug | New search | Development Roadmap | Status: Open | Feedback | All | Closed Since Version 0.2.2dev1 |
| Request #7040 | Support for FormBuilder's _getFieldsToRender | ||
|---|---|---|---|
| Submitted: | 2006-03-06 20:16 UTC | ||
| From: | justinpatrin | Assigned: | olivierg |
| Status: | Bogus | Package: | Structures_DataGrid_DataSource_DataObject (version CVS) |
| PHP Version: | 5.1.1 | OS: | |
| Roadmaps: | (Not assigned) | ||
[2006-03-06 20:16 UTC] justinpatrin
(Justin Patrin)
Description:
------------
I've altered the auto field option generation in te DataObject driver to support FormBuilder's _getFieldsToRender.
http://pear.reversefold.com/SDG_fieldsToRender.patch
Comments
[2006-06-21 15:10 UTC] olivierg at php dot net
(Olivier Guilyardi)
Corrected package name now that bug #7946 is fixed.
[2007-06-13 17:30 UTC] justinpatrin
(Justin Patrin)
The point of this was to use FB's built-in logic for which fields to display rather than having the SDG driver re-do some/all of the logic.
[2007-06-13 17:43 UTC] olivierg
(Olivier Guilyardi)
Sorry, I didn't express myself clearly: what functional improvement does it bring? what issue does it fix?
If the sole purpose is to reuse some parts of FormBuilders's logic within the DataObject driver, I do not agree with this change. FormBuilder deals with rendering, while this driver's job is data access. This is spaghetti code IMO.