Vote Details for "Services_Apns" by till

» Details
Voter: Till Klampaeckel [Wishlist] Vote: +1 (conditional) Reviews: Cursory source review
» Comment
This looks great, thanks for proposing this code. What makes my vote conditional: * What Alan mentioned. * Move constants into the class so they are not in the global scope. * Add some test cases. * Move examples one up.