Vote Details for "Mailman" by cweiske

» Details
» Comment
- No unittests - this is the biggest problem. since you're already using http_request2, you can mock the mail admin away easily.
- Docblock problems like "@return unknown Return description"
- "setdigest" needs to be setDigest
- Code that may have unexpected results:
if ($object instanceof HTTP_Request2) {
$this->req = $object;
} else {
$this->req = new HTTP_Request2();
-> here you just ignore what the user put in since you don't specify the object type in the signature.
- setAdminURL: return; although you write @return boolean
- you should use exceptions instead of setError.

This vote is very conditional.