Vote Details for "PagamentoCerto" by gauthierm

» Details
  • Voter: Michael Gauthier 
  • Vote: +1 (not conditional)
  • Reviews: Cursory source review
» Comment
Great code. I still think you should use an XML API to generate the XML, but as you said, it's on your todo list!

The documentation for constants should be one doc-block per constant. I think there is a shorthand syntax to indicate that the documentation applies to more than one constant. Chuck might know it off the top of his head.

Having all exceptions in one file is allowed in PEAR1 as far as I know. I think it is explicitly forbidden in PEAR2 (due to the autoloading conventions).