Vote Details for "PagamentoCerto" by doconnor

» Details
» Comment
1) should shift up one level.

IE, it should be
require_once 'Payment/PagamentoCerto.php';

2) More heckling re AllTests.php - in where the unit tests live, even if they are a smidge broken at the moment

3) The unit tests should inject a fake soap client which returns dummy results.

Something like:

$client = new MockSoapPaymentPagamentoClient();
$client->addResponse(array(1, 2, 3));

$foo = new Payment_PagamentoCerto($client);

assert($foo->bar() == array(1, 2, 3));

It should also cover off negative test cases - ie, raising exceptions on a HTTP 404 / 403 / 505.

Other than that, LGTM!