Vote Details for "Net_Gearman" by tswicegood

» Details
  • Voter: Travis Swicegood 
  • Vote: +1 (conditional)
  • Reviews: Cursory source review, Deep source review
» Comment
The test config contains a ":" instead of a PATH_SEPARATOR when setting up the tests. Those should be runnable on multiple platforms (even if they fail).

The only other thing is various abstract classes, which we discussed off-line. The abstract keyword is generally accepted to signify a class that is not directly instantiable because it is a super-class, not just that a class is not supposed to be instantiated. I would much rather see those specifically addressed via a private final __construct() that declared abstract so the proper error message is raised when someone does try to instantiate one of those classes.