Vote Details for "File_CAB" by izi

» Details
  • Voter: David Jean Louis 
  • Vote: +1 (not conditional)
  • Reviews: Cursory source review
» Comment
"/usr/bin/" should not be hardcoded, for example on my OS (OpenBSD):
$ sudo pkg_add -i cabextract
cabextract-1.2: complete
$ which cabextract

You should use instead the %bin_dir% variable substitution provided by the pear installer, for example:
const UNIX_COMMAND = '%bin_dir%/cabextract';
and in your package.xml:
<tasks:replace from="@bin_dir@" to="bin_dir" type="pear-config" />

Clean code otherwise, except for some long lines that could be wrapped for more readability IMHO.