Vote Details for "I18N_UnicodeNormalizer" by aharvey

» Details
  • Voter: Adam Harvey 
  • Vote: +1 (conditional)
  • Reviews: Cursory source review, Run examples
» Comment
I had some failures when running the tests; I'll e-mail you the details off-list. I'm +1 assuming those are sorted out.

Side note, although my vote is _not_ conditional on this being changed: I really don't like the long lines in the source either. I can live with it, but I can't help thinking that it would be clearer with the comments above the line in question, rather than beside -- the odd line is wrapping for me, and I'm not using a low resolution or especially large font. Please at least consider reformatting the code to keep comments to a reasonable line length.