Vote Details for "PHP_GenDocBlock" by wiesemann
| » Details |
|---|
|
| » Comment |
|
(comments based on the gendocblock.0.3.tgz file) - linebreak between "class" and "{" is still missing - why is GenDocBlockTest.php in the PHP/ directory and not in the tests/ directory? - to be honest, the run() method is unreadable: * some people already complained about the and's and or's * the comments after the lines "hide" the and's and or's IMHO => I would recommend to put the comment into separate lines and to remove the and's and or's - the "@" error suppression calls are still there, but not needed (they can make debugging very complicated) - comments for run() are also valid for e.g. alignTags(); instead of --- $this->tagPadding = max(array_map('strlen', $tags)); // finds out the length of the longest tag --- I would recommend to use --- // finds out the length of the longest tag $this->tagPadding = max(array_map('strlen', $tags)); --- |