Vote Details for "Util_Array" by alan_k
| » Details |
|---|
|
| » Comment |
|
While there is some value in this, There are a number of problems which justify a -1 - there were no comments during the proposal period, It would have been better to announce on pear-dev that you intended to move it to voting. - the grouping of utilities to files/classes seems mixed and vague. - Some appear redundant (some methods could easily be replaced with a clever array_walk/create_function call) - CS standard are not followed, method names/ class names, etc. { } placement - some of the code has very redundant else /elseif structures. It may be worth considering some of this within a Util_Array class, rather than singular Array_* classes |