Vote Details for "HTML_QuickForm_SelectFilter" by avb

» Details
  • Voter: Alexey Borzov 
  • Vote: +1 (conditional)
  • Reviews: Deep source review
» Comment
This kind of error handling in toHtml() does not seem like a good idea:
function toHtml()
if (count($this->_targets) == 0) {
// this filter as no target!
return 'No target defined!';

You can also help users by automatically registering (using HTML_QuickForm::registerElementType()) the element type on class include.