Vote Details for "DB_odbtp" by danielc

» Details
  • Voter: Daniel Convissor 
  • Vote: +1 (conditional)
  • Reviews: Cursory source review
» Comment
Addressing other's concerns, having this as a standalone pacakge is fine by me.

In general, the code looks really good. Thanks.

I don't like how the 'username' DSN element contains all of this information: $dsninfo['username'] = 'DRIVER={Microsoft Access Driver (*.mdb)};DBQ=c:\NorthWind.mdb;UID=admin;PWD=;';
That needs to be broken down into the proper elements in order to provide portability/comprehendability with DB.

The var declarations need to be on separate lines and need docblocks.
All methods need docblocks

In the class-level docblock, shouldn't the @package be DB_odbtp?

Please clean up the docblock formatting for getSpecialQuery().