Vote Details for "Services_Nabaztag" by till
| » Details |
|---|
|
| » Comment |
|
This is great. And I think I need one. ;( This vote is not conditional, but a few things I wanted to add (IMHO): * get rid off dirname(__FILE__) in your code * some of your if()'s seem pretty complicated (exit/return early where possible) * maybe more single quotes instead of double quotes * there are a few PEAR CS things you should fix (through phpcs) * your Exception class should extend PEAR_Exception |