David Grant [2004-05-13 09:23 UTC] Please provide links to examples of your class in action, rather than examples of what figlet *can* output, and also some documentation.
Tobias Schlitt [2004-05-13 09:23 UTC] Please provide sources as .phps or .html (highlighted) for the package code and example code.
Firman Wandayandi [2004-05-13 09:33 UTC] Ok, I collected what you should provide
1. Package sources *.phps
2. Example code *.phps
3. Example output
4. API documentation (optional)
Firman Wandayandi [2004-05-13 10:49 UTC] Yupz, everything ok :) and the package look nice for me. But I suggest you include more bundle font files. IMHO more easy for everyone to use a bundle font file to create a figlet, seem on your example output you have many enough font files, but in package file only slant.flf. May you include more font files?
Evgeny Stepanischev [2004-05-13 17:05 UTC] I've made everything you suggested.
Arnaud Limbourg [2004-05-20 07:37 UTC] I think that extending PEAR class is a bit too much since it is used only for raiseError.
I suggest that you look at the Error_Stack class or write a custom raiseError method which includes the PEAR base class when needed. There is not really any need to extend it :)
Arnaud Limbourg [2004-05-20 07:38 UTC] I forgot to add that other than the PEAR base class inheriting the rest looks good :)
Evgeny Stepanischev [2004-05-20 12:30 UTC] To Arnaud Limbourg: Hello! Thank you for your comment. Early I've got message form Tobias Schlitt: "Use of a custom error scheme. You should use PEAR::Error when providing errors". I'm not sure what should I do. :))
|
