http://pear.php.net/bugs/search.php?cmd=display&package_name%5B0%5D=Validate_Finance Search Results en-us pear-webmaster@lists.php.net pear-webmaster@lists.php.net hourly 1 2000-01-01T12:00+00:00 http://pear.php.net/gifs/pearsmall.gif http://pear.php.net/bugs http://pear.php.net/bugs/13007 Validate_Finance Feature/Change Request Reported by jausions 2008-01-30T18:10:53+00:00 PHP: Irrelevant OS: Irrelevant Package Version: 0.5.5 Description: ------------ IMO having the country names hardcoded in Validate_Finance_IBAN is not good practice. The user should instead be advised to use I18Nv2_Country instead. Related to that, why not $_iban_countrycode_countryname populate the array directly on the static declaration in _getCountrycodeCountryname(), the isset() section is too much. This method is to basically create a class static property. In the same vein, why again making it static in validate, there's not much to gain, just clutters the code. Also some minor PEAR CS, such as missing spaces around = signs, or after some , commas.]]> Validate_Finance Feature/Change Request Reported by jausions 2008-01-30T18:10:53+00:00 PHP: Irrelevant OS: Irrelevant Package Version: 0.5.5 Description: ------------ IMO having the country names hardcoded in Validate_Finance_IBAN is not good practice. The user should instead be advised to use I18Nv2_Country instead. Related to that, why not $_iban_countrycode_countryname populate the array directly on the static declaration in _getCountrycodeCountryname(), the isset() section is too much. This method is to basically create a class static property. In the same vein, why again making it static in validate, there's not much to gain, just clutters the code. Also some minor PEAR CS, such as missing spaces around = signs, or after some , commas.]]> 2010-04-27T19:57:59+00:00 pear at 11abacus dot com Validate_Finance Feature/Change Request