http://pear.php.net/bugs/search.php?cmd=display&package_name%5B0%5D=Validate_ES Search Results en-us pear-webmaster@lists.php.net pear-webmaster@lists.php.net hourly 1 2000-01-01T12:00+00:00 http://pear.php.net/gifs/pearsmall.gif http://pear.php.net/bugs http://pear.php.net/bugs/20526 Validate_ES Bug Reported by romeurosa 2015-03-25T16:29:22+00:00 PHP: Irrelevant OS: Linux Package Version: Unknown Description: ------------ Taking into consideration the following valid Spanish CIF () This will return 0 from the cif($cif) method found in ES.php. On closer inspection I verified that when you do the final verification: if ((int)$controlCode != $d && $letters2[$d] != $controlCode) { $letters2[$d] for that cif will return F. This is because the array starts at index 0 and not index 1. If you change that for $letters2[$d-1], or shift all the indexes by 1 it will work. Test script: --------------- class ES { function testCIF() { echo 'Result: ' . (int) $this->cif('Q5355149E'); } function cif($cif) { // Same one as in ES.php } } Expected result: ---------------- Result: 1 Actual result: -------------- Result: 0]]> Validate_ES Bug Reported by romeurosa 2015-03-25T16:29:22+00:00 PHP: Irrelevant OS: Linux Package Version: Unknown Description: ------------ Taking into consideration the following valid Spanish CIF () This will return 0 from the cif($cif) method found in ES.php. On closer inspection I verified that when you do the final verification: if ((int)$controlCode != $d && $letters2[$d] != $controlCode) { $letters2[$d] for that cif will return F. This is because the array starts at index 0 and not index 1. If you change that for $letters2[$d-1], or shift all the indexes by 1 it will work. Test script: --------------- class ES { function testCIF() { echo 'Result: ' . (int) $this->cif('Q5355149E'); } function cif($cif) { // Same one as in ES.php } } Expected result: ---------------- Result: 1 Actual result: -------------- Result: 0]]> 2015-03-25T16:29:22+00:00 romeurosa at gmail dot com Validate_ES Bug