http://pear.php.net/bugs/search.php?cmd=display&package_name%5B0%5D=System_Command Search Results en-us pear-webmaster@lists.php.net pear-webmaster@lists.php.net hourly 1 2000-01-01T12:00+00:00 http://pear.php.net/gifs/pearsmall.gif http://pear.php.net/bugs http://pear.php.net/bugs/16558 System_Command Feature/Change Request Reported by ifeghali 2009-08-31T19:14:24+00:00 PHP: 5.2.5 OS: Package Version: 1.0.6 Description: ------------ It would be handy to have an option to kill the command if it is running for a given period of time. A good example is here: http://www.php.net/manual/function.exec.php#89716]]> System_Command Feature/Change Request Reported by ifeghali 2009-08-31T19:14:24+00:00 PHP: 5.2.5 OS: Package Version: 1.0.6 Description: ------------ It would be handy to have an option to kill the command if it is running for a given period of time. A good example is here: http://www.php.net/manual/function.exec.php#89716]]> 2009-08-31T19:14:24+00:00 ifeghali at php dot net System_Command Feature/Change Request http://pear.php.net/bugs/14837 System_Command Documentation Problem Reported by ifeghali 2008-10-20T15:16:48+00:00 PHP: 5.1.6 OS: Package Version: 1.0.6 Description: ------------ This package does not throw exceptions like stated in the documentation. It returns PEAR errors instead.]]> System_Command Documentation Problem Reported by ifeghali 2008-10-20T15:16:48+00:00 PHP: 5.1.6 OS: Package Version: 1.0.6 Description: ------------ This package does not throw exceptions like stated in the documentation. It returns PEAR errors instead.]]> 2009-05-27T05:40:58+00:00 ifeghali at php dot net System_Command Documentation Problem http://pear.php.net/bugs/9504 System_Command Feature/Change Request Reported by joshualross 2006-11-29T20:47:53+00:00 PHP: 5.1.6 OS: Any Package Version: 1.0.5 Description: ------------ System_Command version 1.0.5 It would be beneficial if arguments to pushCommand could be sent as Arrays. In the case I am dealing with I am attempting to zip a large list of files from different directories. The list of files is in an array. I suggest a method that handles arrays by recursing through them. I successfully tested the following rewrite with and without arrays: Command.php@ line 313: $argv = func_get_args(); array_shift($argv); // foreach($argv as $arg) { // if (is_array($arg)) { // // // if (strpos($arg, '-') === 0) { // $command .= ' ' . $arg; // } // elseif ($arg != '') { // $command .= ' ' . escapeshellarg($arg); // } // } $command .= $this->_processArgv($argv); Then add the following method: /** * Used to recursively escape command line arguments * * @param array $argv Arguments for command * * @access private * @return string */ function _processArgv($argv) { $cmd = ''; foreach($argv as $arg) { if (is_array($arg)) { $cmd .= $this->_processArgv($arg); } elseif (strpos($arg, '-') === 0) { $cmd .= ' ' . $arg; } elseif ($arg != '') { $cmd .= ' ' . escapeshellarg($arg); } } return $cmd; } I hope this can be implemented. ;) Test script: --------------- $out_file = '/tmp/test.zip'; $files = array('/tmp/text1.txt', '/tmp/text2.txt'); $options = 'mj9'; $cmd = new System_Command(); $cmd->pushCommand('zip', '-' . $options, $out_file, $files); $rc = $cmd->execute(); Expected result: ---------------- A command like this: /usr/bin/zip -mj9 '/tmp/test.zip' '/tmp/text1.txt' '/tmp/text2.txt' Actual result: -------------- Above returns: /usr/bin/zip -mj9 '/tmp/test.zip' 'Array' If I loop through the files adding a space between files like this: foreach ($files as $file) { $to_zip .= ' ' . $file; } Result: /usr/bin/zip -mj9 '/tmp/test.zip' '/tmp/text1.txt /tmp/text2.txt' The entire string is quoted as it should be but then the command reads the space as part of the filename, hence one long filename instead of multiple files.]]> System_Command Feature/Change Request Reported by joshualross 2006-11-29T20:47:53+00:00 PHP: 5.1.6 OS: Any Package Version: 1.0.5 Description: ------------ System_Command version 1.0.5 It would be beneficial if arguments to pushCommand could be sent as Arrays. In the case I am dealing with I am attempting to zip a large list of files from different directories. The list of files is in an array. I suggest a method that handles arrays by recursing through them. I successfully tested the following rewrite with and without arrays: Command.php@ line 313: $argv = func_get_args(); array_shift($argv); // foreach($argv as $arg) { // if (is_array($arg)) { // // // if (strpos($arg, '-') === 0) { // $command .= ' ' . $arg; // } // elseif ($arg != '') { // $command .= ' ' . escapeshellarg($arg); // } // } $command .= $this->_processArgv($argv); Then add the following method: /** * Used to recursively escape command line arguments * * @param array $argv Arguments for command * * @access private * @return string */ function _processArgv($argv) { $cmd = ''; foreach($argv as $arg) { if (is_array($arg)) { $cmd .= $this->_processArgv($arg); } elseif (strpos($arg, '-') === 0) { $cmd .= ' ' . $arg; } elseif ($arg != '') { $cmd .= ' ' . escapeshellarg($arg); } } return $cmd; } I hope this can be implemented. ;) Test script: --------------- $out_file = '/tmp/test.zip'; $files = array('/tmp/text1.txt', '/tmp/text2.txt'); $options = 'mj9'; $cmd = new System_Command(); $cmd->pushCommand('zip', '-' . $options, $out_file, $files); $rc = $cmd->execute(); Expected result: ---------------- A command like this: /usr/bin/zip -mj9 '/tmp/test.zip' '/tmp/text1.txt' '/tmp/text2.txt' Actual result: -------------- Above returns: /usr/bin/zip -mj9 '/tmp/test.zip' 'Array' If I loop through the files adding a space between files like this: foreach ($files as $file) { $to_zip .= ' ' . $file; } Result: /usr/bin/zip -mj9 '/tmp/test.zip' '/tmp/text1.txt /tmp/text2.txt' The entire string is quoted as it should be but then the command reads the space as part of the filename, hence one long filename instead of multiple files.]]> 2009-06-01T17:38:34+00:00 joshualross at gmail dot com System_Command Feature/Change Request