http://pear.php.net/bugs/search.php?cmd=display&package_name%5B0%5D=Services_Hatena Search Results en-us pear-webmaster@lists.php.net pear-webmaster@lists.php.net hourly 1 2000-01-01T12:00+00:00 http://pear.php.net/gifs/pearsmall.gif http://pear.php.net/bugs http://pear.php.net/bugs/17371 Services_Hatena Feature/Change Request Reported by doconnor 2010-05-06T04:00:34+00:00 PHP: Irrelevant OS: Package Version: SVN Description: ------------ XML_RPC is unmaintained; consider XML_RPC2 as a replacement.]]> Services_Hatena Feature/Change Request Reported by doconnor 2010-05-06T04:00:34+00:00 PHP: Irrelevant OS: Package Version: SVN Description: ------------ XML_RPC is unmaintained; consider XML_RPC2 as a replacement.]]> 2010-05-06T04:00:34+00:00 daniel dot oconnor at gmail dot com Services_Hatena Feature/Change Request http://pear.php.net/bugs/14963 Services_Hatena Feature/Change Request Reported by doconnor 2008-11-06T10:53:00+00:00 PHP: 5.2.6 OS: Package Version: CVS Description: ------------ At the moment, Services_Hatena instantiates XML_RPC clients in the middle of methods to get code. Basically, classes do: class Foo extends Services_Hatena { public function execute() { // new XML_RPC_Client() in here } } If you were to change the API to expect you to instantiate an XML_RPC_Client in the constructor, testability is markedly improved - you can inject a mock client which provides dummy results, but otherwise asserts your package functions correctly. IE - You could do: $service = new Services_Hatena_Bookmarknum(new XML_RPC_Client()); $service = new Services_Hatena_Bookmarknum(new Mock_XML_RPC_Client()); (or pass it in to the factory method) If the factory doesn't get passed any particular arguments, you could still instantiate the relevant XML_RPC client. This would prevent Bug #14872 from ever occurring again.]]> Services_Hatena Feature/Change Request Reported by doconnor 2008-11-06T10:53:00+00:00 PHP: 5.2.6 OS: Package Version: CVS Description: ------------ At the moment, Services_Hatena instantiates XML_RPC clients in the middle of methods to get code. Basically, classes do: class Foo extends Services_Hatena { public function execute() { // new XML_RPC_Client() in here } } If you were to change the API to expect you to instantiate an XML_RPC_Client in the constructor, testability is markedly improved - you can inject a mock client which provides dummy results, but otherwise asserts your package functions correctly. IE - You could do: $service = new Services_Hatena_Bookmarknum(new XML_RPC_Client()); $service = new Services_Hatena_Bookmarknum(new Mock_XML_RPC_Client()); (or pass it in to the factory method) If the factory doesn't get passed any particular arguments, you could still instantiate the relevant XML_RPC client. This would prevent Bug #14872 from ever occurring again.]]> 2008-11-06T10:53:00+00:00 daniel dot oconnor at gmail dot com Services_Hatena Feature/Change Request