http://pear.php.net/bugs/search.php?cmd=display&package_name%5B0%5D=PHP_CodeSniffer Search Results en-us pear-webmaster@lists.php.net pear-webmaster@lists.php.net hourly 1 2000-01-01T12:00+00:00 http://pear.php.net/gifs/pearsmall.gif http://pear.php.net/bugs http://pear.php.net/bugs/20509 PHP_CodeSniffer Feature/Change Request Reported by sebastian 2015-03-02T22:10:12+00:00 PHP: Irrelevant OS: Irrelevant Package Version: 2.2.0 Description: ------------ In a coding standard I want to apply the Generic.Metrics.CyclomaticComplexity and Generic.Metrics.NestingLevel sniffs, for instance, only to specific methods (only public methods where the name starts with a specific prefix, for instance). It would be nice if all sniffs that hook T_METHOD had support for properties such as <property name="methodVisibility" value="public" /> <property name="methodNamePrefix" value="test" />]]> PHP_CodeSniffer Feature/Change Request Reported by sebastian 2015-03-02T22:10:12+00:00 PHP: Irrelevant OS: Irrelevant Package Version: 2.2.0 Description: ------------ In a coding standard I want to apply the Generic.Metrics.CyclomaticComplexity and Generic.Metrics.NestingLevel sniffs, for instance, only to specific methods (only public methods where the name starts with a specific prefix, for instance). It would be nice if all sniffs that hook T_METHOD had support for properties such as <property name="methodVisibility" value="public" /> <property name="methodNamePrefix" value="test" />]]> 2015-03-02T22:10:12+00:00 sb &#x61;&#116; sebastian-bergmann &#x64;&#111;&#x74; de PHP_CodeSniffer Feature/Change Request http://pear.php.net/bugs/20306 PHP_CodeSniffer Feature/Change Request Reported by aik099 2014-06-22T15:00:32+00:00 PHP: 5.4.20 OS: Linux Package Version: 1.5.3 Description: ------------ The Squiz.FunctionComment sniff has hardcoded checks for array/callable types, however it also checks in PHP_CodeSniffer::$allowedTypes array where both of them are listed: http://screencast.com/t/szbpYSsa I suggest that you remove hardcoded checks. Also the "typehint" callable would give Fatal Error in PHP < 5.4, but it's a valid in PHPDoc. Sniff still requires "callable" to be used which is not good.]]> PHP_CodeSniffer Feature/Change Request Reported by aik099 2014-06-22T15:00:32+00:00 PHP: 5.4.20 OS: Linux Package Version: 1.5.3 Description: ------------ The Squiz.FunctionComment sniff has hardcoded checks for array/callable types, however it also checks in PHP_CodeSniffer::$allowedTypes array where both of them are listed: http://screencast.com/t/szbpYSsa I suggest that you remove hardcoded checks. Also the "typehint" callable would give Fatal Error in PHP < 5.4, but it's a valid in PHPDoc. Sniff still requires "callable" to be used which is not good.]]> 2014-07-02T12:00:30+00:00 aik &#x64;&#111;&#x74; bold &#x61;&#116; gmail &#x64;&#111;&#x74; com PHP_CodeSniffer Feature/Change Request http://pear.php.net/bugs/20270 PHP_CodeSniffer Feature/Change Request Reported by senyahnoj 2014-05-09T17:15:01+00:00 PHP: 5.5.12 OS: Linux Package Version: 1.5.3 Description: ------------ I have incorporated your very helpful Superfluous whitespace sniff into our custom coding standard. When using the doc generator this function didn't appear as there is no SuperfluousWhitespaceStandard.xml file in CodeSniffer/Standards/Squiz/Docs/WhiteSpace/ I wrote a quick XML file based on what was written in the sniff class which I've attached but I expect you'll want to write your own ;) Test script: --------------- My custom ruleset.xml has the following node: <rule ref="Squiz.WhiteSpace.SuperfluousWhitespace"/> Then I run: phpcs --generator=HTML --standard=MyCodingStandard Expected result: ---------------- I expected to see the Superfluous whitespace function documented. Actual result: -------------- Superfluous whitespace function did not appear in the outputted documentation.]]> PHP_CodeSniffer Feature/Change Request Reported by senyahnoj 2014-05-09T17:15:01+00:00 PHP: 5.5.12 OS: Linux Package Version: 1.5.3 Description: ------------ I have incorporated your very helpful Superfluous whitespace sniff into our custom coding standard. When using the doc generator this function didn't appear as there is no SuperfluousWhitespaceStandard.xml file in CodeSniffer/Standards/Squiz/Docs/WhiteSpace/ I wrote a quick XML file based on what was written in the sniff class which I've attached but I expect you'll want to write your own ;) Test script: --------------- My custom ruleset.xml has the following node: <rule ref="Squiz.WhiteSpace.SuperfluousWhitespace"/> Then I run: phpcs --generator=HTML --standard=MyCodingStandard Expected result: ---------------- I expected to see the Superfluous whitespace function documented. Actual result: -------------- Superfluous whitespace function did not appear in the outputted documentation.]]> 2014-05-09T17:15:01+00:00 jon &#x61;&#116; senyahnoj &#x64;&#111;&#x74; org &#x64;&#111;&#x74; uk PHP_CodeSniffer Feature/Change Request http://pear.php.net/bugs/20220 PHP_CodeSniffer Feature/Change Request Reported by aik099 2014-03-17T22:49:48+00:00 PHP: 5.4.20 OS: Slackware Linux Package Version: 1.5.2 Description: ------------ The "Squiz_Sniffs_WhiteSpace_ObjectOperatorSpacingSniff" sniff check for "$variable ->method" and for ""$variable-> method" violations (space before/after object operator). This is valid, but when I'm chaining calls using multiline formatting: $this->eventDispatcher ->shouldReceive('dispatch') ->with($event_name, m::any()) ->once(); Then sniff reports it as an error. I think, that in such case when "->" is on the different line then the actual variable or previously chained method, then this shouldn't be considered as violation.]]> PHP_CodeSniffer Feature/Change Request Reported by aik099 2014-03-17T22:49:48+00:00 PHP: 5.4.20 OS: Slackware Linux Package Version: 1.5.2 Description: ------------ The "Squiz_Sniffs_WhiteSpace_ObjectOperatorSpacingSniff" sniff check for "$variable ->method" and for ""$variable-> method" violations (space before/after object operator). This is valid, but when I'm chaining calls using multiline formatting: $this->eventDispatcher ->shouldReceive('dispatch') ->with($event_name, m::any()) ->once(); Then sniff reports it as an error. I think, that in such case when "->" is on the different line then the actual variable or previously chained method, then this shouldn't be considered as violation.]]> 2014-03-24T07:25:20+00:00 aik &#x64;&#111;&#x74; bold &#x61;&#116; gmail &#x64;&#111;&#x74; com PHP_CodeSniffer Feature/Change Request http://pear.php.net/bugs/20216 PHP_CodeSniffer Feature/Change Request Reported by moorereason 2014-03-08T04:02:38+00:00 PHP: Irrelevant OS: CentOS 6 Package Version: 1.5.2 Description: ------------ The use of a List keyword is not validated in the same way that an Array declaration is. Lists are only validated as being lowercase (in Generic.PHP.LowerCaseKeyword). Test script: --------------- list($a, $b) = foo(); // good list(,, $a, $b) = foo(); // good list($a,$b) = foo(); // error - no space after comma list(,,$a, $b) = foo(); // error - space after open paren Expected result: ---------------- I expect a List to be validated similarly to an Array (except without the key=>value features).]]> PHP_CodeSniffer Feature/Change Request Reported by moorereason 2014-03-08T04:02:38+00:00 PHP: Irrelevant OS: CentOS 6 Package Version: 1.5.2 Description: ------------ The use of a List keyword is not validated in the same way that an Array declaration is. Lists are only validated as being lowercase (in Generic.PHP.LowerCaseKeyword). Test script: --------------- list($a, $b) = foo(); // good list(,, $a, $b) = foo(); // good list($a,$b) = foo(); // error - no space after comma list(,,$a, $b) = foo(); // error - space after open paren Expected result: ---------------- I expect a List to be validated similarly to an Array (except without the key=>value features).]]> 2014-03-08T04:02:38+00:00 moorereason &#x61;&#116; gmail &#x64;&#111;&#x74; com PHP_CodeSniffer Feature/Change Request http://pear.php.net/bugs/20127 PHP_CodeSniffer Feature/Change Request Reported by shadyvb 2013-11-12T07:01:00+00:00 PHP: Irrelevant OS: Package Version: 1.5.0RC4 Description: ------------ It'd be handy if we can match token values against a regex token, instead of a simple string.]]> PHP_CodeSniffer Feature/Change Request Reported by shadyvb 2013-11-12T07:01:00+00:00 PHP: Irrelevant OS: Package Version: 1.5.0RC4 Description: ------------ It'd be handy if we can match token values against a regex token, instead of a simple string.]]> 2013-11-12T07:01:00+00:00 shady &#x61;&#116; x-team &#x64;&#111;&#x74; com PHP_CodeSniffer Feature/Change Request http://pear.php.net/bugs/20126 PHP_CodeSniffer Feature/Change Request Reported by shadyvb 2013-11-12T06:55:38+00:00 PHP: Irrelevant OS: Package Version: 1.4.7 Description: ------------ It'd be great if PHPCS has a findNextAll to match against all tokens of a specific criteria, just like what preg_match_all does. The method would still take the same arguments as findNext, and will save quite sometime developing new rules, and will simplify logic of existing ones as well.]]> PHP_CodeSniffer Feature/Change Request Reported by shadyvb 2013-11-12T06:55:38+00:00 PHP: Irrelevant OS: Package Version: 1.4.7 Description: ------------ It'd be great if PHPCS has a findNextAll to match against all tokens of a specific criteria, just like what preg_match_all does. The method would still take the same arguments as findNext, and will save quite sometime developing new rules, and will simplify logic of existing ones as well.]]> 2013-11-12T06:55:38+00:00 shady &#x61;&#116; x-team &#x64;&#111;&#x74; com PHP_CodeSniffer Feature/Change Request http://pear.php.net/bugs/20121 PHP_CodeSniffer Feature/Change Request Reported by happydog 2013-11-05T21:03:26+00:00 PHP: Irrelevant OS: N/A Package Version: 1.4.7 Description: ------------ Currently, if you want to include all committers in the output of the svnblame report, as opposed to just committers who are responsible for 1 or more sniff errors, then you do this by specifying the -v option. However, the -v option also controls the general verbosity of code-sniffer. This therefore generates a lot of unwanted output. Test script: --------------- phpcs --report=svnblame -v Expected result: ---------------- PHP CODE SNIFFER SVN BLAME SUMMARY -------------------------------------------------------------------------------- AUTHOR SOURCE (Author %) (Overall %) COUNT -------------------------------------------------------------------------------- author1 (0.11) (100) 27 author2 (0) (0) 0 -------------------------------------------------------------------------------- A TOTAL OF 27 SNIFF VIOLATION(S) WERE COMMITTED BY 2 AUTHOR(S) -------------------------------------------------------------------------------- Actual result: -------------- Getting SVN blame info for classCache.php... DONE Getting SVN blame info for classCacheBackend_filesystem.php... DONE Getting SVN blame info for classCacheBackend_nocache.php... DONE Getting SVN blame info for ErrorConstants.php... DONE Getting SVN blame info for classlibError.php... DONE Getting SVN blame info for classlibErrorHandling.php... DONE Getting SVN blame info for Input.php... DONE Getting SVN blame info for InputConstants.php... DONE Getting SVN blame info for classInput.php... DONE Getting SVN blame info for classInputCLI.php... DONE Getting SVN blame info for classInputWeb.php... DONE [SNIP] PHP CODE SNIFFER SVN BLAME SUMMARY -------------------------------------------------------------------------------- AUTHOR SOURCE (Author %) (Overall %) COUNT -------------------------------------------------------------------------------- author1 (0.11) (100) 27 author2 (0) (0) 0 -------------------------------------------------------------------------------- A TOTAL OF 27 SNIFF VIOLATION(S) WERE COMMITTED BY 2 AUTHOR(S) -------------------------------------------------------------------------------- The solution would be to provide an alternative argument for svnblame so that showing all users and showing verbose information are decoupled, e.g. phpcs --report=svnblame --all-authors]]> PHP_CodeSniffer Feature/Change Request Reported by happydog 2013-11-05T21:03:26+00:00 PHP: Irrelevant OS: N/A Package Version: 1.4.7 Description: ------------ Currently, if you want to include all committers in the output of the svnblame report, as opposed to just committers who are responsible for 1 or more sniff errors, then you do this by specifying the -v option. However, the -v option also controls the general verbosity of code-sniffer. This therefore generates a lot of unwanted output. Test script: --------------- phpcs --report=svnblame -v Expected result: ---------------- PHP CODE SNIFFER SVN BLAME SUMMARY -------------------------------------------------------------------------------- AUTHOR SOURCE (Author %) (Overall %) COUNT -------------------------------------------------------------------------------- author1 (0.11) (100) 27 author2 (0) (0) 0 -------------------------------------------------------------------------------- A TOTAL OF 27 SNIFF VIOLATION(S) WERE COMMITTED BY 2 AUTHOR(S) -------------------------------------------------------------------------------- Actual result: -------------- Getting SVN blame info for classCache.php... DONE Getting SVN blame info for classCacheBackend_filesystem.php... DONE Getting SVN blame info for classCacheBackend_nocache.php... DONE Getting SVN blame info for ErrorConstants.php... DONE Getting SVN blame info for classlibError.php... DONE Getting SVN blame info for classlibErrorHandling.php... DONE Getting SVN blame info for Input.php... DONE Getting SVN blame info for InputConstants.php... DONE Getting SVN blame info for classInput.php... DONE Getting SVN blame info for classInputCLI.php... DONE Getting SVN blame info for classInputWeb.php... DONE [SNIP] PHP CODE SNIFFER SVN BLAME SUMMARY -------------------------------------------------------------------------------- AUTHOR SOURCE (Author %) (Overall %) COUNT -------------------------------------------------------------------------------- author1 (0.11) (100) 27 author2 (0) (0) 0 -------------------------------------------------------------------------------- A TOTAL OF 27 SNIFF VIOLATION(S) WERE COMMITTED BY 2 AUTHOR(S) -------------------------------------------------------------------------------- The solution would be to provide an alternative argument for svnblame so that showing all users and showing verbose information are decoupled, e.g. phpcs --report=svnblame --all-authors]]> 2013-11-05T21:03:26+00:00 pear &#x61;&#116; kennel17 &#x64;&#111;&#x74; co &#x64;&#111;&#x74; uk PHP_CodeSniffer Feature/Change Request http://pear.php.net/bugs/19939 PHP_CodeSniffer Feature/Change Request Reported by astoyan 2013-05-08T01:25:53+00:00 PHP: Irrelevant OS: Package Version: 1.5.0RC2 Description: ------------ There is a way to define custom ruleset but there is no word about what rules are available and what properties they have. And developers are supposed to google on some hints, use someone's pieces, read source code in order to understand how how use this or that rule, or in order to find a rule needed. This is just stupid. Was it so hard to put a small txt file with the list of rules and their properties?]]> PHP_CodeSniffer Feature/Change Request Reported by astoyan 2013-05-08T01:25:53+00:00 PHP: Irrelevant OS: Package Version: 1.5.0RC2 Description: ------------ There is a way to define custom ruleset but there is no word about what rules are available and what properties they have. And developers are supposed to google on some hints, use someone's pieces, read source code in order to understand how how use this or that rule, or in order to find a rule needed. This is just stupid. Was it so hard to put a small txt file with the list of rules and their properties?]]> 2013-11-27T10:49:03+00:00 alexander &#x64;&#111;&#x74; stoyan &#x61;&#116; gmail &#x64;&#111;&#x74; com PHP_CodeSniffer Feature/Change Request http://pear.php.net/bugs/19404 PHP_CodeSniffer Feature/Change Request Reported by klausi 2012-05-01T06:47:07+00:00 PHP: 5.3.9 OS: Ubuntu 12.04 Package Version: SVN Description: ------------ If you configure Generic_Sniffs_Whitespace_ScopeIndentSniff with $exact = true; then it will throw a few false positives on multi line statements and T_DOC_COMMENTs. Here is a valid example that uses an indentation of 2 spaces. I will also attach a patch how I solved it for drupalcs. Test script: --------------- class Bar { /** * Enter description here ... */ public function foo() { $result = db_select('node') ->condition('type', 'article') ->execute(); } } Expected result: ---------------- There should be no indentation error. Actual result: -------------- The sniff complains about the indentation of the doc block and the chained method invocations.]]> PHP_CodeSniffer Feature/Change Request Reported by klausi 2012-05-01T06:47:07+00:00 PHP: 5.3.9 OS: Ubuntu 12.04 Package Version: SVN Description: ------------ If you configure Generic_Sniffs_Whitespace_ScopeIndentSniff with $exact = true; then it will throw a few false positives on multi line statements and T_DOC_COMMENTs. Here is a valid example that uses an indentation of 2 spaces. I will also attach a patch how I solved it for drupalcs. Test script: --------------- class Bar { /** * Enter description here ... */ public function foo() { $result = db_select('node') ->condition('type', 'article') ->execute(); } } Expected result: ---------------- There should be no indentation error. Actual result: -------------- The sniff complains about the indentation of the doc block and the chained method invocations.]]> 2012-05-08T10:31:08+00:00 klaus &#x64;&#111;&#x74; purer &#x61;&#116; gmail &#x64;&#111;&#x74; com PHP_CodeSniffer Feature/Change Request http://pear.php.net/bugs/18867 PHP_CodeSniffer Feature/Change Request Reported by cweiske 2011-09-23T19:40:49+00:00 PHP: 5.3.8 OS: Package Version: 1.3.0 Description: ------------ When using PHP/CodeSniffer/Standards/Squiz/Sniffs/Debug/JSLintSniff.php, I do not get a warning/notice/error when either of the required paths is not set. I don't have the possibility to find out something is wrong. When someone uses this sniff, phpcs should tell the error and exit with a non-zero exit code.]]> PHP_CodeSniffer Feature/Change Request Reported by cweiske 2011-09-23T19:40:49+00:00 PHP: 5.3.8 OS: Package Version: 1.3.0 Description: ------------ When using PHP/CodeSniffer/Standards/Squiz/Sniffs/Debug/JSLintSniff.php, I do not get a warning/notice/error when either of the required paths is not set. I don't have the possibility to find out something is wrong. When someone uses this sniff, phpcs should tell the error and exit with a non-zero exit code.]]> 2011-09-26T08:33:59+00:00 cweiske &#x61;&#116; php &#x64;&#111;&#x74; net PHP_CodeSniffer Feature/Change Request http://pear.php.net/bugs/18498 PHP_CodeSniffer Feature/Change Request Reported by kingsquare 2011-05-02T17:23:07+00:00 PHP: Irrelevant OS: Ubuntu Package Version: 1.3.0 Description: ------------ Since a while now Douglas Crockford hasnt supported Rhino in his JSLint project. Now including support is fairly straightforward: add this piece of javascript to the end of jslint.js (@see http://thecodetrain.co.uk/2011/04/making-php-codesniffer- use-jslint-via-rhino/) : (function (a) { var e, i, input; if (!a[0]) { print("Usage: jslint.js file.js"); quit(1); } input = readFile(a[0]); if (!input) { print("jslint: Couldn't open file '" + a[0] + "'."); quit(1); } if (!JSLINT(input, {bitwise: true, eqeqeq: true, immed: true, newcap: true, nomen: true, onevar: true, plusplus: true, regexp: true, rhino: true, undef: true, white: true})) { for (i = 0; i < JSLINT.errors.length; i += 1) { e = JSLINT.errors[i]; if (e) { print('Lint at line ' + e.line + ' character ' + e.character + ': ' + e.reason); print((e.evidence || ''). replace(/^\s*(\S*(\s+\S+)*)\s*$/, "$1")); print(''); } } quit(2); } else { print("jslint: No problems found in " + a[0]); quit(); } }(arguments)); and thats it. But this also includes the various options to be set on the JSLint itself. I've modified this into allowing of sending the actuel JSLint configuration object: // rhino.js // 2009-09-11 /* Copyright (c) 2002 Douglas Crockford (www.JSLint.com) Rhino Edition */ // This is the Rhino companion to fulljslint.js. /*global JSLINT */ /*jslint rhino: true, strict: false */ (function (a) { var e, i, input, options = {bitwise: true, eqeqeq: true, immed: true, newcap: true, nomen: true, onevar: true, plusplus: true, regexp: true, rhino: true, undef: true, white: true}; if (!a[0]) { print("Usage: jslint.js file.js"); quit(1); } input = readFile(a[0]); if (!input) { print("jslint: Couldn't open file '" + a[0] + "'."); quit(1); } if (!JSLINT(input, ((!a[1])?options:a[1]))) { for (i = 0; i < JSLINT.errors.length; i += 1) { e = JSLINT.errors[i]; if (e) { print('Lint at line ' + e.line + ' character ' + e.character + ': ' + e.reason); print((e.evidence || ''). replace(/^\s*(\S*(\s+\S+)*)\s*$/, "$1")); print(''); } } quit(2); } else { print("jslint: No problems found in " + a[0]); quit(); } }(arguments)); This would allow the codesniffer rule to send along its configuration: class Squiz_Sniffs_Debug_JSLintSniff: public $jsLintConfig = '{bitwise: true, eqeqeq: true, immed: true, newcap: true, nomen: true, onevar: true, plusplus: true, regexp: true, rhino: true, undef: true, white: true}'; /* .. line 72 ..*/ $cmd = "$rhinoPath \"$jslintPath\" \"$fileName\" \"$this- >jsLintConfig\""; This would allow easier reuse of the sniff via a rule: <rule ref="Squiz.Debug.JSLing"> <properties> <property name="jsLintConfig" value="{plusplus: true, regexp: true, rhino: true, undef: true, white: true}"/> </properties> </rule> instead of having to copy/paste the entire sniff just to allow the setting of custom configuration.. I know the public variable for jsLintConfig is pretty ugly, but this way it works and allows for easier reconfiguration]]> PHP_CodeSniffer Feature/Change Request Reported by kingsquare 2011-05-02T17:23:07+00:00 PHP: Irrelevant OS: Ubuntu Package Version: 1.3.0 Description: ------------ Since a while now Douglas Crockford hasnt supported Rhino in his JSLint project. Now including support is fairly straightforward: add this piece of javascript to the end of jslint.js (@see http://thecodetrain.co.uk/2011/04/making-php-codesniffer- use-jslint-via-rhino/) : (function (a) { var e, i, input; if (!a[0]) { print("Usage: jslint.js file.js"); quit(1); } input = readFile(a[0]); if (!input) { print("jslint: Couldn't open file '" + a[0] + "'."); quit(1); } if (!JSLINT(input, {bitwise: true, eqeqeq: true, immed: true, newcap: true, nomen: true, onevar: true, plusplus: true, regexp: true, rhino: true, undef: true, white: true})) { for (i = 0; i < JSLINT.errors.length; i += 1) { e = JSLINT.errors[i]; if (e) { print('Lint at line ' + e.line + ' character ' + e.character + ': ' + e.reason); print((e.evidence || ''). replace(/^\s*(\S*(\s+\S+)*)\s*$/, "$1")); print(''); } } quit(2); } else { print("jslint: No problems found in " + a[0]); quit(); } }(arguments)); and thats it. But this also includes the various options to be set on the JSLint itself. I've modified this into allowing of sending the actuel JSLint configuration object: // rhino.js // 2009-09-11 /* Copyright (c) 2002 Douglas Crockford (www.JSLint.com) Rhino Edition */ // This is the Rhino companion to fulljslint.js. /*global JSLINT */ /*jslint rhino: true, strict: false */ (function (a) { var e, i, input, options = {bitwise: true, eqeqeq: true, immed: true, newcap: true, nomen: true, onevar: true, plusplus: true, regexp: true, rhino: true, undef: true, white: true}; if (!a[0]) { print("Usage: jslint.js file.js"); quit(1); } input = readFile(a[0]); if (!input) { print("jslint: Couldn't open file '" + a[0] + "'."); quit(1); } if (!JSLINT(input, ((!a[1])?options:a[1]))) { for (i = 0; i < JSLINT.errors.length; i += 1) { e = JSLINT.errors[i]; if (e) { print('Lint at line ' + e.line + ' character ' + e.character + ': ' + e.reason); print((e.evidence || ''). replace(/^\s*(\S*(\s+\S+)*)\s*$/, "$1")); print(''); } } quit(2); } else { print("jslint: No problems found in " + a[0]); quit(); } }(arguments)); This would allow the codesniffer rule to send along its configuration: class Squiz_Sniffs_Debug_JSLintSniff: public $jsLintConfig = '{bitwise: true, eqeqeq: true, immed: true, newcap: true, nomen: true, onevar: true, plusplus: true, regexp: true, rhino: true, undef: true, white: true}'; /* .. line 72 ..*/ $cmd = "$rhinoPath \"$jslintPath\" \"$fileName\" \"$this- >jsLintConfig\""; This would allow easier reuse of the sniff via a rule: <rule ref="Squiz.Debug.JSLing"> <properties> <property name="jsLintConfig" value="{plusplus: true, regexp: true, rhino: true, undef: true, white: true}"/> </properties> </rule> instead of having to copy/paste the entire sniff just to allow the setting of custom configuration.. I know the public variable for jsLintConfig is pretty ugly, but this way it works and allows for easier reconfiguration]]> 2011-05-02T17:23:07+00:00 pear &#x61;&#116; kingsquare &#x64;&#111;&#x74; nl PHP_CodeSniffer Feature/Change Request http://pear.php.net/bugs/18468 PHP_CodeSniffer Feature/Change Request Reported by sigmaz 2011-04-21T12:12:39+00:00 PHP: 5.3.6 OS: Windows Package Version: 1.3.0 Description: ------------ On Windows the exclude-pattern must be defined with escaped backslashes. For example: <exclude-pattern>*\\test\\*</exclude-pattern> Expected result: ---------------- It would be great, if exclude-pattern definitions would be the same like on UNIX. Example: <exclude-pattern>*/test/*</exclude-pattern> May be the directory separator could be converted internally by PHP_CodeSniffer, so that example above would work, too. Actual result: -------------- All files will be queued to be sniffed.]]> PHP_CodeSniffer Feature/Change Request Reported by sigmaz 2011-04-21T12:12:39+00:00 PHP: 5.3.6 OS: Windows Package Version: 1.3.0 Description: ------------ On Windows the exclude-pattern must be defined with escaped backslashes. For example: <exclude-pattern>*\\test\\*</exclude-pattern> Expected result: ---------------- It would be great, if exclude-pattern definitions would be the same like on UNIX. Example: <exclude-pattern>*/test/*</exclude-pattern> May be the directory separator could be converted internally by PHP_CodeSniffer, so that example above would work, too. Actual result: -------------- All files will be queued to be sniffed.]]> 2011-04-28T04:57:38+00:00 steff &#x64;&#111;&#x74; zeidler &#x61;&#116; googlemail &#x64;&#111;&#x74; com PHP_CodeSniffer Feature/Change Request http://pear.php.net/bugs/13813 PHP_CodeSniffer Feature/Change Request Reported by blacksheepkhan 2008-04-30T20:50:03+00:00 PHP: Irrelevant OS: Irrelevant Package Version: 1.1.0a1 Description: ------------ When the new ScopeIndentSniff is being extended to switch the "exact" boolean parameter on then it does not take in account doc indents. Reason: We want to have all indents fixed to 4 spaces, not more. But documentation (inline) lines should be ignored because they are checked elsewhere. Test script: --------------- class anything { /** * test */ public function xxxx Expected result: ---------------- No report expected because doc starts with 4 spaces and public also... The 1 space difference from within the doc (line * test and */) should be ignored. Actual result: -------------- Switching "exact" on throws error on "* test" and "*/" being 5 chars indent. Switching "exact" would not throw an error when indention is more than 4 for public or other lines.]]> PHP_CodeSniffer Feature/Change Request Reported by blacksheepkhan 2008-04-30T20:50:03+00:00 PHP: Irrelevant OS: Irrelevant Package Version: 1.1.0a1 Description: ------------ When the new ScopeIndentSniff is being extended to switch the "exact" boolean parameter on then it does not take in account doc indents. Reason: We want to have all indents fixed to 4 spaces, not more. But documentation (inline) lines should be ignored because they are checked elsewhere. Test script: --------------- class anything { /** * test */ public function xxxx Expected result: ---------------- No report expected because doc starts with 4 spaces and public also... The 1 space difference from within the doc (line * test and */) should be ignored. Actual result: -------------- Switching "exact" on throws error on "* test" and "*/" being 5 chars indent. Switching "exact" would not throw an error when indention is more than 4 for public or other lines.]]> 2011-04-07T11:55:19+00:00 thomas &#x64;&#111;&#x74; weidner &#x61;&#116; gmx &#x64;&#111;&#x74; at PHP_CodeSniffer Feature/Change Request