PEAR Bug Search Results

Numbers_Words: Bug 21226 [Verified] es_AR

harlyman dot facebook at gmail dot com — 2017-07-07T12:16:09+00:00

Numbers_Words Bug
Reported by harlyman
2017-07-06T12:42:20+00:00
PHP: 5.6.30 OS: Debian Package Version: 0.18.1

Description:
------------
mejoras en el manejo de valores terminados en uno en los 
decimales
function _toWords($num, $power = 0, $powerDec = false) {

...

case 2:
                if ($d == 0) {
                    $ret .= $this->_sep . 'veinte';
                } else {
                    if ((($power > 1) and ( $d == 1)) or ($powerDec 
and $d == 1)) {
                        $ret .= $this->_sep . 'veintiÃºn';
                    } else {
                        $ret .= $this->_sep . 'veinti' . $this-
>_digits[$d];
                    }
                }
                break;

...

// add digits only if it is a multiple of 10 and not 1x or 2x
        if (($t != 1) and ( $t != 2) and ( $d > 0)) {

            // don't add 'y' for numbers below 10
            if ($t != 0) {
                // use 'un' instead of 'uno' when there is a suffix 
('mil', 'millones', etc...)
                if (($power > 0) and ( $d == 1) or ($powerDec and 
$d == 1)) {
                    $ret .= $this->_sep . ' y un';
                } else {
                    $ret .= $this->_sep . 'y ' . $this->_digits[$d];
                }
            } else {
                if (($power > 0) and ( $d == 1) or ($powerDec and 
$d == 1)) {
                    $ret .= $this->_sep . 'un';
                } else {
                    $ret .= $this->_sep . $this->_digits[$d];
                }
            }
        }

Test script:
---------------
$ntl = new NumerosLetras();
echo $ntl->toCurrency(41531321021.21, "es_AR");

Expected result:
----------------
Pesos cuarenta y un mil quinientos treinta y un millones 
trescientos veintiÃºn mil veintiuno con veintiÃºn centavos

Actual result:
--------------
Pesos cuarenta y un mil quinientos treinta y un millones 
trescientos veintiÃºn mil veintiuno con veintiuno centavos

Numbers_Words: Bug 20544 [Open] Missing spaces in nl

baudouin dot laloy at gmail dot com — 2015-05-07T22:45:20+00:00

Numbers_Words Bug
Reported by baud
2015-05-07T21:38:51+00:00
PHP: 5.5.9 OS: Ubuntu Package Version: 0.18.1

Description:
------------
If you use 55000 as an input, you get 'vijfenvijftigDuizend' in NL.
=>A space is missing before 'Duizend'
If you use 55500 as an input, you get 'vijfenvijftigDuizendvijfhonderd'
=>Two spaces are missing: before and after 'Duizend'

Test script:
---------------
$num="55000";
$numberToWord = new Numbers_Words();
$ret= $numberToWord->toWords($num,'nl');
echo $ret;

Expected result:
----------------
result should be: vijfenvijftig Duizend

Actual result:
--------------
result is: vijfenvijftigDuizend

Numbers_Words: Bug 20495 [Open] Long-scale naming vs Short-scale naming

shehi at imanov dot name — 2015-01-29T22:32:52+00:00

Numbers_Words Bug
Reported by shehriyari
2015-01-29T22:32:52+00:00
PHP: Irrelevant OS: All Package Version: SVN

Description:
------------
@see http://en.wikipedia.org/wiki/Long_and_short_scales#English-speaking

As you can see from this source, there are two naming conventions for large numbers 
in West. Generally most continental Europe and Latin America use some weird 
method called "long-scale" where numbers' names in Short-scale (which is used by 
the rest of the world) are used **wrongly**. Now, thing is, when I viewed en_GB 
language version file of this package, I noticed such discrepancies in the naming of 
numbers. E.g.:

10^12 is called "billion" whereas in English -speaking world, 10^9 is billion.
10^12 is "trillion" and so on, so forth.

All seems OK in en_US version tho.

Please check the code against this topic and make relevant fixes. Because it is VERY 
confusing. 

Test script:
---------------
$this->assertEquals('two billion', $this->handle->toWords(2000000000, $this->lang));

Expected result:
----------------
two billion

Actual result:
--------------
thousand million

Numbers_Words: Feature/Change Request 16732 [Assigned] Charsets/Locale should be handled

pahan at hubbitus dot spb dot su — 2009-10-27T16:26:39+00:00

Numbers_Words Feature/Change Request
Reported by hubbitus
2009-10-23T18:05:57+00:00
PHP: 5.3.0 OS: Linux Package Version: 0.16.1

Description:
------------
Numbers_Words::toCurrency($price, setlocale(NULL), 'RUR'); should work properly. Or, in another way first example:
Numbers_Words::toCurrency($price, 'ru_RU.UTF-8', 'RUR');
provide all needed information in standardized way: Country, language, charset.

Numbers_Words: Feature/Change Request 15166 [Open] Think about generating an E_NOTICE if PHP_INT_SIZE is exceeded

daniel dot oconnor at gmail dot com — 2012-03-23T06:14:14+00:00

Numbers_Words Feature/Change Request
Reported by doconnor
2008-11-26T13:19:52+00:00
PHP: 5.2.6 OS:  Package Version: CVS

Description:
------------
If you pass in an argument to toWords(); and it's larger than PHP_INT_SIZE; it won't work as expected.

The easiest way to work around it is to cast it to a string.

This is surprising to junior developers, and we should generate a helpful notice or warning if we can.

Numbers_Words: Feature/Change Request 15146 [Open] DRY - refactor common, duplicated code

daniel dot oconnor at gmail dot com — 2008-11-25T03:55:54+00:00

Numbers_Words Feature/Change Request
Reported by doconnor
2008-11-24T21:53:04+00:00
PHP: 5.2.6 OS:  Package Version: CVS

Description:
------------
Many of the drivers have common code in toWords() - ie, they do it the same as english.

Consider implementing a utility class or refactoring into the parent class.

Example duplicate code:
      if (strlen($num) > 3) {
          $maxp = strlen($num)-1;
          $curp = $maxp;
          for ($p = $maxp; $p > 0; --$p) { // power
            
            // check for highest power
            if (isset($this->_exponent[$p])) {
              // send substr from $curp to $p
              $snum = substr($num, $maxp - $curp, $curp - $p + 1);
              $snum = preg_replace('/^0+/','',$snum);
              if ($snum !== '') {
                  $cursuffix = $this->_exponent[$power][count($this->_exponent[$power])-1];
                    if ($powsuffix != '') {
                        $cursuffix .= $this->_sep . $powsuffix;
                    }
                  $ret .= $this->toWords($snum, $p, $cursuffix);
              }
              $curp = $p - 1;
              continue;
            }
          }
          $num = substr($num, $maxp - $curp, $curp - $p + 1);
          if ($num == 0) {
              return $ret;
          }
      } elseif ($num == 0 || $num == '') {
        return $this->_sep . $this->_digits[0];
      }