PEAR Bug Search Results

Numbers_Words: Bug 16733 [Assigned] Integral part treated incorrectly

pahan at hubbitus dot spb dot su — 2009-10-27T12:10:20+00:00

Numbers_Words Bug
Reported by hubbitus
2009-10-23T13:25:54+00:00
PHP: 5.3.0 OS: Linux Package Version: 0.16.1

Description:
------------
Numbers_Words::toCurrency(44.555, 'en_US'): string(48) "forty-four dollars five hundred fifty-five cents"

It's incorrect - in this example "five hundred fifty-five cents" is $5.55 instead of 56cents!. Fractional part must be rounded to 2 digits before convert.

Fix is trivial, I'll do not include patch.

Numbers_Words: Feature/Change Request 16732 [Assigned] Charsets/Locale should be handled

pahan at hubbitus dot spb dot su — 2009-10-27T12:26:39+00:00

Numbers_Words Feature/Change Request
Reported by hubbitus
2009-10-23T13:05:57+00:00
PHP: 5.3.0 OS: Linux Package Version: 0.16.1

Description:
------------
Numbers_Words::toCurrency($price, setlocale(NULL), 'RUR'); should work properly. Or, in another way first example:
Numbers_Words::toCurrency($price, 'ru_RU.UTF-8', 'RUR');
provide all needed information in standardized way: Country, language, charset.

Numbers_Words: Feature/Change Request 16667 [Open] hungarian 40 is incorrect

pear at lavela dot hu — 2009-10-02T11:36:42+00:00

Numbers_Words Feature/Change Request
Reported by vlajos
2009-10-01T12:42:20+00:00
PHP: 5.2.2 OS: Linux Package Version: 0.16.1

Description:
------------
The package says "nÃ©gyven", but the correct is "negyven". (without accent.)

I attached a fixed lang.hu_HU.php.

Numbers_Words: Bug 16435 [Analyzed] improper use of substr() in lang.pl.php

santaslh428660843 at spamherelots dot com — 2009-10-27T12:27:56+00:00

Numbers_Words Bug
Reported by santaslh
2009-07-14T00:05:03+00:00
PHP: 5.2.5 OS:  Package Version: 0.16.1

Description:
------------
in function _get_numlevel($num)
line
$num = (int)substr($num, -3);
doesn't return desired result when strlen($num) < 3
see: http://php.net/manual/en/function.substr.php#75999

Test script:
---------------
print Numbers_Words::toCurrency(1,'pl','PLN');
print Numbers_Words::toCurrency(3,'pl','PLN');


Expected result:
----------------
jeden złotych
trzy złotych



Actual result:
--------------
jeden złoty
trzy złote

Numbers_Words: Feature/Change Request 15166 [Open] Think about generating an E_NOTICE if PHP_INT_SIZE is exceeded

daniel dot oconnor at gmail dot com — 2008-11-26T08:19:52+00:00

Numbers_Words Feature/Change Request
Reported by doconnor
2008-11-26T08:19:52+00:00
PHP: 5.2.6 OS:  Package Version: CVS

Description:
------------
If you pass in an argument to toWords(); and it's larger than PHP_INT_SIZE; it won't work as expected.

The easiest way to work around it is to cast it to a string.

This is surprising to junior developers, and we should generate a helpful notice or warning if we can.

Numbers_Words: Feature/Change Request 15146 [Open] DRY - refactor common, duplicated code

daniel dot oconnor at gmail dot com — 2008-11-24T22:55:54+00:00

Numbers_Words Feature/Change Request
Reported by doconnor
2008-11-24T16:53:04+00:00
PHP: 5.2.6 OS:  Package Version: CVS

Description:
------------
Many of the drivers have common code in toWords() - ie, they do it the same as english.

Consider implementing a utility class or refactoring into the parent class.

Example duplicate code:
      if (strlen($num) > 3) {
          $maxp = strlen($num)-1;
          $curp = $maxp;
          for ($p = $maxp; $p > 0; --$p) { // power
            
            // check for highest power
            if (isset($this->_exponent[$p])) {
              // send substr from $curp to $p
              $snum = substr($num, $maxp - $curp, $curp - $p + 1);
              $snum = preg_replace('/^0+/','',$snum);
              if ($snum !== '') {
                  $cursuffix = $this->_exponent[$power][count($this->_exponent[$power])-1];
                    if ($powsuffix != '') {
                        $cursuffix .= $this->_sep . $powsuffix;
                    }
                  $ret .= $this->toWords($snum, $p, $cursuffix);
              }
              $curp = $p - 1;
              continue;
            }
          }
          $num = substr($num, $maxp - $curp, $curp - $p + 1);
          if ($num == 0) {
              return $ret;
          }
      } elseif ($num == 0 || $num == '') {
        return $this->_sep . $this->_digits[0];
      }

Numbers_Words: Bug 12512 [Verified] incorrect declaration of toWords() in lang.fr.php (and others!)

niconours1 at yahoo dot fr — 2008-12-02T12:46:27+00:00

Numbers_Words Bug
Reported by ndeguine
2007-11-23T10:10:59+00:00
PHP: 5.2.4 OS: Windows Package Version: 0.15.0

Description:
------------
In lang.fr.php, the toWords method is defined as this :

function toWords($num = 0)

When I call this method, I have the following message :

Strict Standards: Declaration of Numbers_Words_fr::toWords() should be compatible with that of Numbers_Words::toWords() in C:\php\PEAR\Numbers\Words\lang.fr.php
 on line 438.

We should have this :

function toWords($num = 0, $power = 0, $powsuffix = '')

The previous line can solve this bug.

Test script:
---------------
echo $nw->toWords(100000,'fr') ;