http://pear.php.net/bugs/search.php?cmd=display&package_name%5B0%5D=Net_URL_Mapper Search Results en-us pear-webmaster@lists.php.net pear-webmaster@lists.php.net hourly 1 2000-01-01T12:00+00:00 http://pear.php.net/gifs/pearsmall.gif http://pear.php.net/bugs http://pear.php.net/bugs/16675 Net_URL_Mapper Feature/Change Request Reported by till 2009-10-03T18:25:31+00:00 PHP: Irrelevant OS: n/a Package Version: CVS Description: ------------ Not sure why Net_URL_Mapper depends on it, but here's an update to Net_URL2.]]> Net_URL_Mapper Feature/Change Request Reported by till 2009-10-03T18:25:31+00:00 PHP: Irrelevant OS: n/a Package Version: CVS Description: ------------ Not sure why Net_URL_Mapper depends on it, but here's an update to Net_URL2.]]> 2009-10-19T08:41:10+00:00 till at php dot net Net_URL_Mapper Feature/Change Request http://pear.php.net/bugs/16050 Net_URL_Mapper Bug Reported by ciarang 2009-03-20T20:36:40+00:00 PHP: Irrelevant OS: Etch Package Version: 0.9.0 Description: ------------ If you match a URL that contains a query string, then supply additional parameters when attempting to generate a new URL, the generator doesn't take into account the existing parameters and so incorrectly adds a '?' where an '&' is required. For example, match: connect('search/notice?q=:q', array('action' => 'noticesearch'),array('q' => '.+')); Then pass the following into generate(): $args - ( [action] => noticesearch, [q] => x) $params - ([p] => 1 ) Instead of getting back "/search/notice?q=x&p=1" you get the invalid "/search/notice?q=x?p=1". Test script: --------------- This fixes it... --- a/extlib/Net/URL/Mapper/Path.php +++ b/extlib/Net/URL/Mapper/Path.php @@ -241,7 +241,12 @@ class Net_URL_Mapper_Path } $path = '/'.trim(Net_URL::resolvePath($path), '/'); if (!empty($qstring)) { - $path .= '?'.http_build_query($qstring); + if (!strpos($path, '?')) { + $path .= '?'; + } else { + $path .= '&'; + } + $path .= http_build_query($qstring); } if (!empty($anchor)) { $path .= '#'.ltrim($anchor, '#');]]> Net_URL_Mapper Bug Reported by ciarang 2009-03-20T20:36:40+00:00 PHP: Irrelevant OS: Etch Package Version: 0.9.0 Description: ------------ If you match a URL that contains a query string, then supply additional parameters when attempting to generate a new URL, the generator doesn't take into account the existing parameters and so incorrectly adds a '?' where an '&' is required. For example, match: connect('search/notice?q=:q', array('action' => 'noticesearch'),array('q' => '.+')); Then pass the following into generate(): $args - ( [action] => noticesearch, [q] => x) $params - ([p] => 1 ) Instead of getting back "/search/notice?q=x&p=1" you get the invalid "/search/notice?q=x?p=1". Test script: --------------- This fixes it... --- a/extlib/Net/URL/Mapper/Path.php +++ b/extlib/Net/URL/Mapper/Path.php @@ -241,7 +241,12 @@ class Net_URL_Mapper_Path } $path = '/'.trim(Net_URL::resolvePath($path), '/'); if (!empty($qstring)) { - $path .= '?'.http_build_query($qstring); + if (!strpos($path, '?')) { + $path .= '?'; + } else { + $path .= '&'; + } + $path .= http_build_query($qstring); } if (!empty($anchor)) { $path .= '#'.ltrim($anchor, '#');]]> 2009-03-20T20:36:40+00:00 ciaran at ciarang dot com Net_URL_Mapper Bug