http://pear.php.net/bugs/search.php?cmd=display&package_name%5B0%5D=Net_URL2 Search Results en-us pear-webmaster@lists.php.net pear-webmaster@lists.php.net hourly 1 2000-01-01T12:00+00:00 http://pear.php.net/gifs/pearsmall.gif http://pear.php.net/bugs http://pear.php.net/bugs/14399 Net_URL2 Bug Reported by rkirilov 2008-07-24T10:20:46+00:00 PHP: 5.2.4 OS: Package Version: 0.2.0 Description: ------------ The patches provided speak for themselves. 1) Missing value for the second parameter of $this->setOption At line 133 - $this->setOption($optionName); + $this->setOption($optionName, $value); 2) The query string should contain anything to the fragment separator, and can be '' (empty string) At line 151 - if (preg_match('@^\?([^#]+)@', $url, $reg)) { + if (preg_match('@^\?([^#]*)@', $url, $reg)) { 3) There are some missing (unused) properties that are tried to be set, and not the right one At line 311 - $this->user = false; + $this->userinfo = false; At line 312 - $this->pass = false; 4) The userinfo (user:pass) can be omitted/empty but in that case there is no need from @ separator in the normalized url At line 315 - if (preg_match('@^(([^\@]+)\@)?([^:]+)(:(\d*))?$@', $authority, $reg)) { + if (preg_match('@^(([^\@]*)\@)?([^:]+)(:(\d*))?$@', $authority, $reg)) { At line 316 - if ($reg[1]) { + if ($reg[1] && strlen($reg[2])) { P.S First I would like to apologize for the bad posted bug report (may be). Second I haven`t read RFCs but I tested the behavior with common browsers.]]> Net_URL2 Bug Reported by rkirilov 2008-07-24T10:20:46+00:00 PHP: 5.2.4 OS: Package Version: 0.2.0 Description: ------------ The patches provided speak for themselves. 1) Missing value for the second parameter of $this->setOption At line 133 - $this->setOption($optionName); + $this->setOption($optionName, $value); 2) The query string should contain anything to the fragment separator, and can be '' (empty string) At line 151 - if (preg_match('@^\?([^#]+)@', $url, $reg)) { + if (preg_match('@^\?([^#]*)@', $url, $reg)) { 3) There are some missing (unused) properties that are tried to be set, and not the right one At line 311 - $this->user = false; + $this->userinfo = false; At line 312 - $this->pass = false; 4) The userinfo (user:pass) can be omitted/empty but in that case there is no need from @ separator in the normalized url At line 315 - if (preg_match('@^(([^\@]+)\@)?([^:]+)(:(\d*))?$@', $authority, $reg)) { + if (preg_match('@^(([^\@]*)\@)?([^:]+)(:(\d*))?$@', $authority, $reg)) { At line 316 - if ($reg[1]) { + if ($reg[1] && strlen($reg[2])) { P.S First I would like to apologize for the bad posted bug report (may be). Second I haven`t read RFCs but I tested the behavior with common browsers.]]> 2008-07-27T04:23:12+00:00 rkirilow at gmail dot com Net_URL2 Bug