http://pear.php.net/bugs/search.php?cmd=display&package_name%5B0%5D=Net_URL2 Search Results en-us pear-webmaster@lists.php.net pear-webmaster@lists.php.net hourly 1 2000-01-01T12:00+00:00 http://pear.php.net/gifs/pearsmall.gif http://pear.php.net/bugs http://pear.php.net/bugs/21153 Net_URL2 Bug Reported by jayklehr 2016-12-10T00:52:20+00:00 PHP: 5.6.27 OS: osx Package Version: 2.1.2 Description: ------------ I noticed when running some tests against Net_URL2 that stray/non-matching brackets (like those used in the query string test of the library) are encoded with %5B and %5D, but if the brackets are the result of building from a PHP array, they're not encoded. This appears to be because of this line in URL2.php: > $name = $key . '[' . $name . ']'; The `rawurlencode` for the $key parameter happens earlier in this method, so the brackets remain untouched. Test script: --------------- <?php $url = new Net_URL2(''); $url->setQuery('key1[=value&key2[]=value'); $vars = $url->getQueryVariables(); $url->setQueryVariables($vars); $newString = $url->getQuery(); var_export($newString); Expected result: ---------------- 'key1%5B=value&key2%5B%5D=value' Actual result: -------------- 'key1%5B=value&key2[]=value']]> Net_URL2 Bug Reported by jayklehr 2016-12-10T00:52:20+00:00 PHP: 5.6.27 OS: osx Package Version: 2.1.2 Description: ------------ I noticed when running some tests against Net_URL2 that stray/non-matching brackets (like those used in the query string test of the library) are encoded with %5B and %5D, but if the brackets are the result of building from a PHP array, they're not encoded. This appears to be because of this line in URL2.php: > $name = $key . '[' . $name . ']'; The `rawurlencode` for the $key parameter happens earlier in this method, so the brackets remain untouched. Test script: --------------- <?php $url = new Net_URL2(''); $url->setQuery('key1[=value&key2[]=value'); $vars = $url->getQueryVariables(); $url->setQueryVariables($vars); $newString = $url->getQuery(); var_export($newString); Expected result: ---------------- 'key1%5B=value&key2%5B%5D=value' Actual result: -------------- 'key1%5B=value&key2[]=value']]> 2016-12-10T00:52:20+00:00 jay &#x61;&#116; diablomedia &#x64;&#111;&#x74; com Net_URL2 Bug http://pear.php.net/bugs/20425 Net_URL2 Bug Reported by pracj3am 2014-10-09T06:23:40+00:00 PHP: Irrelevant OS: Package Version: 2.0.9 Description: ------------ When parsing URI, characters that are invalid are percent-encoded in the userinfo, path and query part (method _encodeData). But there are more characters that should be percent-encoded according to rfc3986 like [ ] | ` { }. Concretely this is the whole set: [\x-\x20\x22\x3C\x3E\5B-\5E\x60\7B-\7D\7F-\FF] Also the same charcters should be pecent-encoded in a fragment part. Test script: --------------- echo (new Net_URL2('http://user[1]@example.com/p\s/|" ?{}#^'))->getUrl(); Expected result: ---------------- http://user%5B1%5D@example.com/p%5Cs/%7C%22%20?%7B%7D#%5E Actual result: -------------- http://user[1]@example.com/p\s/|%22%20?{}#^]]> Net_URL2 Bug Reported by pracj3am 2014-10-09T06:23:40+00:00 PHP: Irrelevant OS: Package Version: 2.0.9 Description: ------------ When parsing URI, characters that are invalid are percent-encoded in the userinfo, path and query part (method _encodeData). But there are more characters that should be percent-encoded according to rfc3986 like [ ] | ` { }. Concretely this is the whole set: [\x-\x20\x22\x3C\x3E\5B-\5E\x60\7B-\7D\7F-\FF] Also the same charcters should be pecent-encoded in a fragment part. Test script: --------------- echo (new Net_URL2('http://user[1]@example.com/p\s/|" ?{}#^'))->getUrl(); Expected result: ---------------- http://user%5B1%5D@example.com/p%5Cs/%7C%22%20?%7B%7D#%5E Actual result: -------------- http://user[1]@example.com/p\s/|%22%20?{}#^]]> 2014-12-29T16:57:03+00:00 jan &#x64;&#111;&#x74; prachar &#x61;&#116; gmail &#x64;&#111;&#x74; com Net_URL2 Bug