http://pear.php.net/bugs/search.php?cmd=display&package_name%5B0%5D=HTML_QuickForm_Livesearch Search Results en-us pear-webmaster@lists.php.net pear-webmaster@lists.php.net hourly 1 2000-01-01T12:00+00:00 http://pear.php.net/gifs/pearsmall.gif http://pear.php.net/bugs http://pear.php.net/bugs/14064 HTML_QuickForm_Livesearch Bug Reported by shangxiao 2008-06-04T02:25:27+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ When the menu is activated, attempting to scroll before the first option or past the final option will show strange behaviour and cause javascript errors. If I scroll past the first option the following error is reported by FF2: Error: document.getElementById(GetResult).firstChild.firstChild has no properties If I scroll past the final option, first no options are highlighted, then upon pressing the down arrow again, the first option becomes highlighted.]]> HTML_QuickForm_Livesearch Bug Reported by shangxiao 2008-06-04T02:25:27+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ When the menu is activated, attempting to scroll before the first option or past the final option will show strange behaviour and cause javascript errors. If I scroll past the first option the following error is reported by FF2: Error: document.getElementById(GetResult).firstChild.firstChild has no properties If I scroll past the final option, first no options are highlighted, then upon pressing the down arrow again, the first option becomes highlighted.]]> 2008-07-12T09:07:36+00:00 shang dot xiao dot sanders at gmail dot com HTML_QuickForm_Livesearch Bug http://pear.php.net/bugs/14054 HTML_QuickForm_Livesearch Feature/Change Request Reported by shangxiao 2008-06-03T09:15:02+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ When no results comeback, you need an option to display a message informing the user that nothing was returned. If the message is empty then the div should be hidden. Currently when nothing came back, your div seems to display a thin line on my FF for mac.]]> HTML_QuickForm_Livesearch Feature/Change Request Reported by shangxiao 2008-06-03T09:15:02+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ When no results comeback, you need an option to display a message informing the user that nothing was returned. If the message is empty then the div should be hidden. Currently when nothing came back, your div seems to display a thin line on my FF for mac.]]> 2008-06-03T09:15:02+00:00 shang dot xiao dot sanders at gmail dot com HTML_QuickForm_Livesearch Feature/Change Request http://pear.php.net/bugs/14037 HTML_QuickForm_Livesearch Feature/Change Request Reported by shangxiao 2008-06-01T03:00:22+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ Include the ability to supply a list of options where the livesearch function fetches the options from a local associative javascript array rather than using a remote ajax connection. Obviously this setup may mean larger HTML files, longer form loading times and options which aren't updated-to-the-second, but this is beneficial for providing rapid deployment without the overhead of setting up an ajax server. This may also be sufficient for a lot of applications that just need a way to get around long and cumbersome select lists.]]> HTML_QuickForm_Livesearch Feature/Change Request Reported by shangxiao 2008-06-01T03:00:22+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ Include the ability to supply a list of options where the livesearch function fetches the options from a local associative javascript array rather than using a remote ajax connection. Obviously this setup may mean larger HTML files, longer form loading times and options which aren't updated-to-the-second, but this is beneficial for providing rapid deployment without the overhead of setting up an ajax server. This may also be sufficient for a lot of applications that just need a way to get around long and cumbersome select lists.]]> 2008-06-01T03:00:22+00:00 shang dot xiao dot sanders at gmail dot com HTML_QuickForm_Livesearch Feature/Change Request http://pear.php.net/bugs/14031 HTML_QuickForm_Livesearch Bug Reported by shangxiao 2008-05-30T12:45:47+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ When I first saw that the callbacks had to be the same name as the element id, I thought it was a bit strange, but just left it as is. Now I see a problem with this design. Quite often database designs will have multiple foreign keys referencing the same table. When using formbuilder to represent this table and livesearch as the field type to search the foreign table (needing to search all in exactly the same way), then this shows the limitation of livesearch's design. Eg: I have 3 foreign keys referencing a table of schools. I want them to all act the same way, but Livesearch forces me to create 3 separate remote callbacks with the ids of each of the fields, seeing as HTML requires that ids are unique. Of course the workaround would be to have 3 unique functions which reference the same function, but workarounds are a symptom of poor design ;) This could easily get out of hand for an app with a larger number. I also like to name my functions with action phrases and my element ids do not look like my function names. So forcing people to use function names the same as element ids makes the code a bit harder to understand. And lastly, it took me a while to figure this out as there's no documentation and the example didn't state this important relationship. I had to go into the livesearch code to figure this out. I believe there should be an option called "reverse_callback" to set the name of the remote callback (as this callback does a reverse lookup of your options). Additionally, the "callback" option should be renamed to "forward_callback" as this does the opposite. Again I'd be happy to supply a patch as I need to get this plugin to do these things asap and I'll probably attempt to modify them myself.]]> HTML_QuickForm_Livesearch Bug Reported by shangxiao 2008-05-30T12:45:47+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ When I first saw that the callbacks had to be the same name as the element id, I thought it was a bit strange, but just left it as is. Now I see a problem with this design. Quite often database designs will have multiple foreign keys referencing the same table. When using formbuilder to represent this table and livesearch as the field type to search the foreign table (needing to search all in exactly the same way), then this shows the limitation of livesearch's design. Eg: I have 3 foreign keys referencing a table of schools. I want them to all act the same way, but Livesearch forces me to create 3 separate remote callbacks with the ids of each of the fields, seeing as HTML requires that ids are unique. Of course the workaround would be to have 3 unique functions which reference the same function, but workarounds are a symptom of poor design ;) This could easily get out of hand for an app with a larger number. I also like to name my functions with action phrases and my element ids do not look like my function names. So forcing people to use function names the same as element ids makes the code a bit harder to understand. And lastly, it took me a while to figure this out as there's no documentation and the example didn't state this important relationship. I had to go into the livesearch code to figure this out. I believe there should be an option called "reverse_callback" to set the name of the remote callback (as this callback does a reverse lookup of your options). Additionally, the "callback" option should be renamed to "forward_callback" as this does the opposite. Again I'd be happy to supply a patch as I need to get this plugin to do these things asap and I'll probably attempt to modify them myself.]]> 2008-07-12T09:06:56+00:00 shang dot xiao dot sanders at gmail dot com HTML_QuickForm_Livesearch Bug http://pear.php.net/bugs/14029 HTML_QuickForm_Livesearch Feature/Change Request Reported by shangxiao 2008-05-30T12:09:11+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ Ok, I think I have this one figured out: To help avoid confusion with results in high latency situations and to bring the behaviour of Livesearch more into line with Google's suggest, I reckon it'd be good to have a delayed-hiding of the menu when the user begins to type. The reason is because when the user has typed a few characters and decides it's not enough or completely starts over, the menu results may no longer apply. In a high latency situation this may give the user the impression that the live search isn't working correctly giving incorrect results. To avoid any flickering of the menu, the hiding feature must be delayed by, say, 1/2 a second. I believe this is what Google's suggest does. Try typing a few characters. See what comes up. Choose the longest response in the menu and attempt to type the rest of it. You'll notice that sometimes the menu disappears if it's busy fetching a new one. Occasionally if the response is quick enough it won't hide, but just be replaced by the new set of results. To achieve this you'd simply set a timeout to hide the menu whenever any character is entered. When the response from the server is received then the menu will reappear with the new results. I'd be happy to supply a patch if you think this is a good idea.]]> HTML_QuickForm_Livesearch Feature/Change Request Reported by shangxiao 2008-05-30T12:09:11+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ Ok, I think I have this one figured out: To help avoid confusion with results in high latency situations and to bring the behaviour of Livesearch more into line with Google's suggest, I reckon it'd be good to have a delayed-hiding of the menu when the user begins to type. The reason is because when the user has typed a few characters and decides it's not enough or completely starts over, the menu results may no longer apply. In a high latency situation this may give the user the impression that the live search isn't working correctly giving incorrect results. To avoid any flickering of the menu, the hiding feature must be delayed by, say, 1/2 a second. I believe this is what Google's suggest does. Try typing a few characters. See what comes up. Choose the longest response in the menu and attempt to type the rest of it. You'll notice that sometimes the menu disappears if it's busy fetching a new one. Occasionally if the response is quick enough it won't hide, but just be replaced by the new set of results. To achieve this you'd simply set a timeout to hide the menu whenever any character is entered. When the response from the server is received then the menu will reappear with the new results. I'd be happy to supply a patch if you think this is a good idea.]]> 2008-05-30T12:09:11+00:00 shang dot xiao dot sanders at gmail dot com HTML_QuickForm_Livesearch Feature/Change Request http://pear.php.net/bugs/14026 HTML_QuickForm_Livesearch Bug Reported by shangxiao 2008-05-30T08:14:22+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ *Note* This is currently only an issue for me with FF2 on Mac. This is not an issue for Safari 3. I haven't tested IE, FF or Safari on Windows. When making a selection from the menu using the arrow keys, a user would expect that after highlighting the wanted item, that pressing the tab key would bring the focus onto the next form field (or whatever the next element would be in the taborder). This is not what is happening. Nothing seems to gain focus. Expected result: ---------------- The next field in the taborder to gain focus. Actual result: -------------- Nothing gains focus.]]> HTML_QuickForm_Livesearch Bug Reported by shangxiao 2008-05-30T08:14:22+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ *Note* This is currently only an issue for me with FF2 on Mac. This is not an issue for Safari 3. I haven't tested IE, FF or Safari on Windows. When making a selection from the menu using the arrow keys, a user would expect that after highlighting the wanted item, that pressing the tab key would bring the focus onto the next form field (or whatever the next element would be in the taborder). This is not what is happening. Nothing seems to gain focus. Expected result: ---------------- The next field in the taborder to gain focus. Actual result: -------------- Nothing gains focus.]]> 2008-07-12T08:59:56+00:00 shang dot xiao dot sanders at gmail dot com HTML_QuickForm_Livesearch Bug http://pear.php.net/bugs/14025 HTML_QuickForm_Livesearch Bug Reported by shangxiao 2008-05-30T08:08:28+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ After typing some text in the text field, then using the arrow keys to navigate through the menu, the hidden input field assumes the correct value of the item selected. However upon pressing escape (or tab for that matter) to close the menu, the hidden field value is erased, but the selected text still appears in the text field. Note that this does not happen if the menu is closed with a selection made using the mouse. Expected result: ---------------- Hidden input field to assume the value of the text in the text field Actual result: -------------- Hidden input field's value is erased]]> HTML_QuickForm_Livesearch Bug Reported by shangxiao 2008-05-30T08:08:28+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ After typing some text in the text field, then using the arrow keys to navigate through the menu, the hidden input field assumes the correct value of the item selected. However upon pressing escape (or tab for that matter) to close the menu, the hidden field value is erased, but the selected text still appears in the text field. Note that this does not happen if the menu is closed with a selection made using the mouse. Expected result: ---------------- Hidden input field to assume the value of the text in the text field Actual result: -------------- Hidden input field's value is erased]]> 2008-07-12T08:58:02+00:00 shang dot xiao dot sanders at gmail dot com HTML_QuickForm_Livesearch Bug http://pear.php.net/bugs/14024 HTML_QuickForm_Livesearch Feature/Change Request Reported by shangxiao 2008-05-30T06:44:00+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ Not sure if you've thought about this but it'd be helpful to have a certain size of the menu and page the list so that the menu doesn't bleed off the bottom edge of the screen. It'd also helpful to utilise the page-up and page-down keys to jump between the pages. This sounds a bit complicated so I'd say this'd be a lower priority.]]> HTML_QuickForm_Livesearch Feature/Change Request Reported by shangxiao 2008-05-30T06:44:00+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ Not sure if you've thought about this but it'd be helpful to have a certain size of the menu and page the list so that the menu doesn't bleed off the bottom edge of the screen. It'd also helpful to utilise the page-up and page-down keys to jump between the pages. This sounds a bit complicated so I'd say this'd be a lower priority.]]> 2008-05-30T09:44:32+00:00 shang dot xiao dot sanders at gmail dot com HTML_QuickForm_Livesearch Feature/Change Request http://pear.php.net/bugs/14023 HTML_QuickForm_Livesearch Bug Reported by shangxiao 2008-05-30T06:20:47+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ Currently the text input is only filtered on what looks to be escape, arrow keys, and whatever 13 is. If I have the text field highlighted and I start pressing other control keys like control, shift, caps lock, alt, apple command, page up, page down, etc ... then unnecessary requests are sent to the ajax server. To cut down on the amount of network traffic and server requests, only visual characters should trigger a request.]]> HTML_QuickForm_Livesearch Bug Reported by shangxiao 2008-05-30T06:20:47+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ Currently the text input is only filtered on what looks to be escape, arrow keys, and whatever 13 is. If I have the text field highlighted and I start pressing other control keys like control, shift, caps lock, alt, apple command, page up, page down, etc ... then unnecessary requests are sent to the ajax server. To cut down on the amount of network traffic and server requests, only visual characters should trigger a request.]]> 2008-07-12T08:57:08+00:00 shang dot xiao dot sanders at gmail dot com HTML_QuickForm_Livesearch Bug http://pear.php.net/bugs/14022 HTML_QuickForm_Livesearch Feature/Change Request Reported by shangxiao 2008-05-30T05:58:14+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ A delay is needed when typing into the livesearch text field to prevent flooding the AJAX server with requests every time a key is pressed. Eg: In the application that I'm setting up, users will type the name of a school. Schools here are often named after their suburb. There might be 3-4 schools in the one suburb. Eg: A suburb called Hawthorn might have "HawthornPrimary School", "Hawthorn Secondary School", "Hawthorn North Primary School", etc. The user will typically start typing "Hawthorn" until a shortlist appears that they can just navigate to. Typically in the past I've always setup delays so that the ajax server isn't flooded with unnecessary requests for "H", "Ha", "Haw", "Hawt", ...., etc. I've found a delay of 250ms to be beneficial, but of course, you'd want to make this an option that you can modify. I'd be happy to upload a patch if you need.]]> HTML_QuickForm_Livesearch Feature/Change Request Reported by shangxiao 2008-05-30T05:58:14+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ A delay is needed when typing into the livesearch text field to prevent flooding the AJAX server with requests every time a key is pressed. Eg: In the application that I'm setting up, users will type the name of a school. Schools here are often named after their suburb. There might be 3-4 schools in the one suburb. Eg: A suburb called Hawthorn might have "HawthornPrimary School", "Hawthorn Secondary School", "Hawthorn North Primary School", etc. The user will typically start typing "Hawthorn" until a shortlist appears that they can just navigate to. Typically in the past I've always setup delays so that the ajax server isn't flooded with unnecessary requests for "H", "Ha", "Haw", "Hawt", ...., etc. I've found a delay of 250ms to be beneficial, but of course, you'd want to make this an option that you can modify. I'd be happy to upload a patch if you need.]]> 2008-06-03T06:16:35+00:00 shang dot xiao dot sanders at gmail dot com HTML_QuickForm_Livesearch Feature/Change Request http://pear.php.net/bugs/14021 HTML_QuickForm_Livesearch Feature/Change Request Reported by shangxiao 2008-05-30T05:32:00+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ To make it easier for packaging, deployment and rapid development (which is what QF is designed for), it'd be beneficial to include the javascript in live.js inside the html that this plugin outputs. I see that you've already got conditional outputting for the styles with your HTML_QUICKFORM_LIVESEARCH_EXISTS constant, so this javascript could easily go into that. This way this plugin would be 1 step less in setup overhead and 1 step closer to being plug-n-play.]]> HTML_QuickForm_Livesearch Feature/Change Request Reported by shangxiao 2008-05-30T05:32:00+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ To make it easier for packaging, deployment and rapid development (which is what QF is designed for), it'd be beneficial to include the javascript in live.js inside the html that this plugin outputs. I see that you've already got conditional outputting for the styles with your HTML_QUICKFORM_LIVESEARCH_EXISTS constant, so this javascript could easily go into that. This way this plugin would be 1 step less in setup overhead and 1 step closer to being plug-n-play.]]> 2008-05-31T07:59:41+00:00 shang dot xiao dot sanders at gmail dot com HTML_QuickForm_Livesearch Feature/Change Request http://pear.php.net/bugs/14020 HTML_QuickForm_Livesearch Feature/Change Request Reported by shangxiao 2008-05-30T04:29:18+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ In keeping with the "let people choose their own names for things" approach the hardcoded classname "livesearch" in your javascript should be dynamically allocated.]]> HTML_QuickForm_Livesearch Feature/Change Request Reported by shangxiao 2008-05-30T04:29:18+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ In keeping with the "let people choose their own names for things" approach the hardcoded classname "livesearch" in your javascript should be dynamically allocated.]]> 2008-06-02T10:52:42+00:00 shang dot xiao dot sanders at gmail dot com HTML_QuickForm_Livesearch Feature/Change Request http://pear.php.net/bugs/14009 HTML_QuickForm_Livesearch Feature/Change Request Reported by shangxiao 2008-05-29T03:11:35+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ The $dbh option being passed into the option lookup callback clutters up the package. People can access their db handles through global functions or object properties. The callback parameters should purely be reserved for variable data coming from the plugin. Seeing as this is a beta release, API changes are acceptable.]]> HTML_QuickForm_Livesearch Feature/Change Request Reported by shangxiao 2008-05-29T03:11:35+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ The $dbh option being passed into the option lookup callback clutters up the package. People can access their db handles through global functions or object properties. The callback parameters should purely be reserved for variable data coming from the plugin. Seeing as this is a beta release, API changes are acceptable.]]> 2008-05-29T15:10:49+00:00 shang dot xiao dot sanders at gmail dot com HTML_QuickForm_Livesearch Feature/Change Request http://pear.php.net/bugs/14008 HTML_QuickForm_Livesearch Feature/Change Request Reported by shangxiao 2008-05-29T02:50:06+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ The user should be able to specify not only the location of the server script but the name as well. Forcing people to use "auto_server.php" is unacceptable.]]> HTML_QuickForm_Livesearch Feature/Change Request Reported by shangxiao 2008-05-29T02:50:06+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ The user should be able to specify not only the location of the server script but the name as well. Forcing people to use "auto_server.php" is unacceptable.]]> 2008-06-02T10:38:28+00:00 shang dot xiao dot sanders at gmail dot com HTML_QuickForm_Livesearch Feature/Change Request http://pear.php.net/bugs/14004 HTML_QuickForm_Livesearch Bug Reported by shangxiao 2008-05-28T13:18:03+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ After the livesearch menu is activated and you make a selection the menu disappears. When the up or down arrows are pressed, the value in the text field changes but the menu does not reappear. This is confusing and also inconsistent with Google's Suggest functionality. Expected result: ---------------- Livesearch menu to reappear upon pressing up or down arrows. Actual result: -------------- Livesearch menu does not reappear.]]> HTML_QuickForm_Livesearch Bug Reported by shangxiao 2008-05-28T13:18:03+00:00 PHP: 5.2.6 OS: Irrelevant Package Version: 0.4.0 Description: ------------ After the livesearch menu is activated and you make a selection the menu disappears. When the up or down arrows are pressed, the value in the text field changes but the menu does not reappear. This is confusing and also inconsistent with Google's Suggest functionality. Expected result: ---------------- Livesearch menu to reappear upon pressing up or down arrows. Actual result: -------------- Livesearch menu does not reappear.]]> 2008-05-29T15:22:57+00:00 shang dot xiao dot sanders at gmail dot com HTML_QuickForm_Livesearch Bug