PEAR Bug Search Results

HTML_QuickForm2: Feature/Change Request 16807 [Open] Input type 'file' should check for POST form

addw at phcomp dot co dot uk — 2009-11-20T00:06:51+00:00

HTML_QuickForm2 Feature/Change Request
Reported by addw
2009-11-19T19:30:09+00:00
PHP: 5.3.0 OS: any Package Version: 0.3.0

Description:
------------
If an addElement of type 'file' is done it should check that the form is a POST form - otherwise it won't work.
It should also complain if the encoding type is not multipart/form-data

Maybe people should know -- I suspect that many will get this wrong.

HTML_QuickForm2: Feature/Change Request 15618 [Open] [patch] support arrayAccess interface

pear at sebastianmendel dot de — 2009-01-13T14:05:07+00:00

HTML_QuickForm2 Feature/Change Request
Reported by cybot
2009-01-12T10:28:51+00:00
PHP: Irrelevant OS:  Package Version: CVS

Description:
------------
These patch implements arrayAccess Interface into HTML_QuickForm2_Container

HTML_QuickForm2: Bug 13088 [Open] using ajax i can't validate

a dot visinoni at autron dot it — 2008-02-09T09:48:41+00:00

HTML_QuickForm2 Bug
Reported by vizzz
2008-02-08T06:15:40+00:00
PHP: 5.2.4 OS: Linux Package Version: 0.2.0

Description:
------------
I'm using ajax to fill options of a  , when i submit the form i can't see in $form->getValue(); data from the ajax populated select.

Test script:
---------------
$fsText->addElement('text', 'txMatricola', array('style' => 'width: 300px;'), array('label' => 'Matricola:'));
$fsText->addElement('select', 'selProduttore', array('style' => 'width: 200px;','onchange' => 'makeRequest(\'getmodelsbyprod.php\', \'selModello-0\',this.value)'), array('options' => $data_prod, 'label' => 'Produttore:'));
$fsText->addElement('select', 'selModello', array('style' => 'width: 200px;'), array('label' => 'Modello:'));
$fsText->addElement('submit', 'btSubmit', array('value' => 'Invia'));
$fsText->addElement('hidden', 'hidValue');

Expected result:
----------------
i expect to see even an "selModello" entry in the array of results after validate.

Actual result:
--------------
array(5) { ["_qf__matricola"]=>  string(0) "" ["txMatricola"]=>  string(3) "abc" ["selProduttore"]=>  string(1) "2" ["btSubmit"]=>  string(5) "Invia" ["hidValue"]=>  string(0) "" }

HTML_QuickForm2: Bug 12065 [Open] Disabled (frozen) elements not accessible

2007-09-17T07:39:12+00:00

HTML_QuickForm2 Bug
Reported by nfreear
2007-09-17T07:39:12+00:00
PHP: Irrelevant OS: Irrelevant Package Version: 0.1.0

Description:
------------
When a "frozen" (disabled) form element is displayed with QuickForm, it is not displayed as expected with a disabled="disabled" attribute - instead QuickForm tries to give a plain text equivalent. This is a usability and accessibility problem:

1. It loses uniform appearance with the rest of the user interface, and will confuse some users.
2. For non-visual users using screen reader software this text may not be read and in any case will not make sense (More here, http://docs.moodle.org/en/Development:Accessibility_notes#Forms).

Applies to, at least: Input, InputCheckbox, InputPassword, InputRadio

HTML 4, disabled attribute,
http://www.w3.org/TR/html4/interact/forms.html#adef-disabled

We use QuickForm in Moodle - for the moment we have fixed it at our level, but really it needs fixing in the QuickForm2 base classes,
http://tracker.moodle.org/browse/MDL-8627

(Reported for HTML_QuickForm as Bug # 12063)

Expected result:
----------------
Checkbox example: label 

Actual result:
--------------
Checkbox example: label [ ], or [x]

HTML_QuickForm2: Feature/Change Request 10617 [Open] Filter optional parameters

buchanae at osuosl dot org — 2007-04-06T16:48:22+00:00

HTML_QuickForm2 Feature/Change Request
Reported by buchanae
2007-04-04T17:44:46+00:00
PHP: 5.1.2 OS: Ubuntu Package Version: 

Description:
------------
Hello,

Apologies in advance if this is an inappropriate place to post this question.

The question relates to applying a filter to an element.  The syntax is

$form->applyFilter($element_name, $filter_callback);

My question is, what if the callback accepts parameters of some kind?  Is this worthy of a feature request?

Could it be as easy as adding an optional parameter to applyFilter and passing that to _recursiveFilter, then adding it to $value when you call_user_func?

Thanks in advance.

Cheers!
Alex

HTML_QuickForm2: Feature/Change Request 10193 [Open] [patch] add addOptionalElement() to HTML_Quickform

greg at mtechsolutions dot ca — 2007-03-07T12:26:17+00:00

HTML_QuickForm2 Feature/Change Request
Reported by greg@...
2007-02-26T10:52:17+00:00
PHP: Irrelevant OS:  Package Version: 

Description:
------------
This may be a bit too specialized for Quickform, but I will submit the patch anyways in case someone has some interest. I also welcome feedback on the implementation.

Adds an addOptionalElement() function that adds an element which includes a checkbox next to it. If the checkbox is not selected, the element is disabled set to a 'standard value' (defined in the call to addOptionalElement()). If checked, the element becomes active and the user can set it to whatever they want. If a default value is passed via HTML_Quickform::setDefaults(), the checkbox is selected, and the default value is shown in the control. If a constant is specified with HTML_Quickform::setConstants(), the value of the control is set to the constant, and the checkbox is disabled.

The element can be any quickform element, and this requires patch 10191 (http://pear.php.net/bugs/10191).

Note that this does require prototype.js (http://www.prototypejs.org/) and prototypeUtils.js (http://jehiah.cz/archive/form-element-setvalue - for the JS function setValue()). Although it could probably be written in native JS, for my purposes prototype is fine, and I don't see much point putting in the effort and duplicating their code if this patch is in fact too specific to be added to HTML_Quickform anyways.

Original patch: http://freepbx.org/trac/changeset/3815

Test script:
---------------
Index: /freepbx/branches/quickform/amp_conf/htdocs/admin/common/HTML/QuickForm/optionalgroup.php
===================================================================
--- /freepbx/branches/quickform/amp_conf/htdocs/admin/common/HTML/QuickForm/optionalgroup.php (revision 3815)
+++ /freepbx/branches/quickform/amp_conf/htdocs/admin/common/HTML/QuickForm/optionalgroup.php (revision 3815)
@@ -0,0 +1,199 @@
+                        |
+// |          Bertrand Mansion                      |
+// +----------------------------------------------------------------------+
+//
+// $Id: group.php,v 1.38 2006/01/11 17:13:20 mansion Exp $
+
+require_once("HTML/QuickForm/group.php");
+
+/**
+ * HTML class for a form element group
+ * 
+ * @author       Adam Daniel 
+ * @author       Bertrand Mansion 
+ * @version      1.0
+ * @since        PHP4.04pl1
+ * @access       public
+ */
+class HTML_QuickForm_optionalgroup extends HTML_QuickForm_group
+{
+	var $_real_name;
+	var $_standard_value;
+	
+	var $_ele_standard = 0;
+	var $_ele_checkbox = 2;
+	var $_ele_control = 1;
+	
+    // {{{ constructor
+
+    /**
+     * Class constructor
+     * 
+     * @param     mixed     $standardValue  (optional)The value to use if the user doesn't specify a value.
+	 *                                      If an array is passed, uses $standardValue[$elementName] if found.
+     * @param     string    $elementName    (optional)The name of the element
+     * @param     array     $elementLabel   (optional)The label to use
+     * @param     array     $elementObject  (optional)The element to use as the main control
+     * @since     1.0
+     * @access    public
+     * @return    void
+     */
+    function HTML_QuickForm_optionalgroup($standardValue=null, $elementName=null, $elementLabel=null, $elementObject=null)
+    {   
+        if (is_null($elementObject)) {
+			return;
+		}
+		
+		if (is_array($standardValue) && isset($standardValue[$elementName])) {
+			$this->_standard_value = $standardValue[$elementName];
+		} else {
+			$this->_standard_value = $standardValue;
+		}
+		
+		$elementObject->_generateId();
+        $id = $elementObject->getAttribute('id');
+		
+		$this->_real_name = $elementObject->getName();
+		
+        $elements = array();
+		// hidden element to store default value
+        $elements[$this->_ele_standard] =& HTML_QuickForm::createElement('hidden', 'qf_default_'.$elementName, null); 
+		$elements[$this->_ele_standard]->_generateId();
+		$hidden_id = $elements[$this->_ele_standard]->getAttribute('id');
+		
+		// checkbox element, to select that real element is editable
+        /*
+		$checkattrs = array(
+            'onclick' => //javascript
+                'if (this.checked) { '.
+                '   document.getElementById(\''.$id.'\').disabled = false; '.
+                '   document.getElementById(\''.$id.'\').class = \'disabled\'; '.
+                '} else { '.
+                '   document.getElementById(\''.$id.'\').disabled = true; '.
+                '   document.getElementById(\''.$id.'\').class = \'\'; '.
+                '   document.getElementById(\''.$id.'\').value = document.getElementById(\''.$hidden_id.'\').value;'.
+                '   document.getElementById(\''.$id.'\').focus();'.
+                '}',
+        );
+		*/
+		$checkattrs = array(
+            'onclick' => //javascript
+                'if (this.checked) { '.
+                '   $(\''.$id.'\').enable();'.
+                '   $(\''.$id.'\').class = \'disabled\'; '.
+                '} else { '.
+                '   $(\''.$id.'\').disable();'.
+                '   $(\''.$id.'\').class = \'\'; '.
+                '   Form.Element.setValue(\''.$id.'\', $(\''.$hidden_id.'\').getValue() );'.
+                '   $(\''.$id.'\').activate();'.
+                '}  alert($(\''.$id.'\').class);',
+			'title' => 'Enable/disable this control',
+			'class' => 'enablercheck',
+        );
+		
+		
+		$elements[$this->_ele_checkbox] =& HTML_QuickForm::createElement('checkbox', 'qf_checkbox_'.$elementName, null, null, $checkattrs);
+		
+		// real control element
+		$elements[$this->_ele_control] =& $elementObject;
+        
+		ksort($elements);
+		
+		//'qf_optionalgroup_'.$elementName
+        parent::HTML_QuickForm_group($elementName, $elementLabel, $elements, ' ', true);
+    } //end constructor
+    
+    // }}}
+
+    // {{{ onQuickFormEvent()
+
+    /**
+     * Called by HTML_QuickForm whenever form event is made on this element
+     *
+     * @param     string    $event  Name of event
+     * @param     mixed     $arg    event arguments
+     * @param     object    $caller calling object
+     * @since     1.0
+     * @access    public
+     * @return    void
+     */
+    function onQuickFormEvent($event, $arg, &$caller)
+    {
+        switch ($event) {
+            case 'updateValue':
+                $this->_createElementsIfNotExist();
+                // elements[0] is hidden default element
+				// elements[1] is checkbox,
+                // elements[2] is actual control
+				
+                // constant values override both default and submitted ones
+                // default values are overriden by submitted
+                if (isset($caller->_constantValues[$this->getName()])) {
+                    // constant in use, so this is always checked, and textbox is always disabled
+	                $this->_elements[$this->_ele_checkbox]->setChecked(false);
+                    $this->_elements[$this->_ele_checkbox]->setDisabled(true);
+                    $this->_elements[$this->_ele_checkbox]->addClass('disabled');
+                    
+                    $this->_elements[$this->_ele_control]->setDisabled(true);
+                    $this->_elements[$this->_ele_control]->addClass('disabled');
+                    $this->_elements[$this->_ele_control]->setValue($caller->_constantValues[$this->getName()]);
+                } else {
+					// checkbox control is enabled
+                    $this->_elements[$this->_ele_checkbox]->setDisabled(false);
+                    $this->_elements[$this->_ele_checkbox]->removeClass('disabled');
+                    
+                    // get the 'standard' value
+                    $default = isset($caller->_defaultValues[$this->getName()]) ? $caller->_defaultValues[$this->getName()] : null;
+                    
+					// save default value to the form
+					//TODO $this->_elements[0]->setValue($default);
+					$this->_elements[0]->setValue($this->_standard_value);
+					
+                    if ($caller->isSubmitted() && isset($caller->_submitValues[$this->getName()]) 
+                      && $caller->_submitValues[$this->getName()] != $this->_standard_value) {
+                        // submitted, not using "standard"
+                        $this->_elements[$this->_ele_checkbox]->setChecked(true);
+                        $this->_elements[$this->_ele_control]->setDisabled(false);
+                        $this->_elements[$this->_ele_control]->removeClass('disabled');
+                        $this->_elements[$this->_ele_control]->setValue($caller->_submitValues[$this->getName()]);
+                    } else if ($default) {
+						// not submitted, and a default is set
+						$this->_elements[$this->_ele_checkbox]->setChecked(true);
+                        $this->_elements[$this->_ele_control]->setDisabled(false);
+                        $this->_elements[$this->_ele_control]->removeClass('disabled');
+                        $this->_elements[$this->_ele_control]->setValue($default);
+					} else {
+                        // not submitted, or value is = standard value
+                        $this->_elements[$this->_ele_checkbox]->setChecked(false);
+                        $this->_elements[$this->_ele_control]->setDisabled(true);
+                        $this->_elements[$this->_ele_control]->addClass('disabled');
+                        $this->_elements[$this->_ele_control]->setValue($this->_standard_value);
+                    }
+                }
+
+                break;
+
+            default:
+                parent::onQuickFormEvent($event, $arg, $caller);
+        }
+        return true;
+    } // end func onQuickFormEvent
+
+    // }}}
+
+}
Index: /freepbx/branches/quickform/amp_conf/htdocs/admin/common/HTML/QuickForm.php
===================================================================
--- /freepbx/branches/quickform/amp_conf/htdocs/admin/common/HTML/QuickForm.php (revision 3661)
+++ /freepbx/branches/quickform/amp_conf/htdocs/admin/common/HTML/QuickForm.php (revision 3815)
@@ -49,4 +49,5 @@
             'xbutton'       =>array('HTML/QuickForm/xbutton.php','HTML_QuickForm_xbutton'),
             'advmultiselect'=>array('HTML/QuickForm/advmultiselect.php','HTML_QuickForm_advmultiselect'),
+            'optionalgroup' =>array('HTML/QuickForm/optionalgroup.php','HTML_QuickForm_optionalgroup'),
         );
 
@@ -727,4 +728,40 @@
         return $group;
     } // end func addGroup
+    
+    // }}}
+	// {{{ addOptionalElement()
+
+    /**
+     * Adds an optional element, using a checkbox
+     * @param    array      $elements       array of elements composing the group
+     * @param    string     $name           (optional)group name
+     * @param    string     $groupLabel     (optional)group label
+     * @param    string     $separator      (optional)string to separate elements
+     * @param    string     $appendName     (optional)specify whether the group name should be
+     *                                      used in the form element name ex: group[element]
+     * @return   object     reference to added group of elements
+     * @since    2.8
+     * @access   public
+     * @throws   PEAR_Error
+     */
+    function &addOptionalElement($element, $name, $standardValue, $groupLabel /*, optional multiple params.. */)
+    {
+        if (is_object($element) && is_subclass_of($element, 'html_quickform_element')) {
+           $elementObject = &$element;
+        } else {
+			// get arguments for elementObject
+            $args = array_slice(func_get_args(),3); 
+			array_unshift($args, null); // stick null on the beginning (element name)
+			
+			$elementObject =& $this->_loadElement('addElement', $element, $args);
+            if (PEAR::isError($elementObject)) {
+                return $elementObject;
+            }
+        }
+        
+		$group =& $this->addElement('optionalgroup', $standardValue, $name, $groupLabel, $elementObject);
+        return $group;
+		
+    } // end func addOptionalElement
     
     // }}}

HTML_QuickForm2: Feature/Change Request 9922 [Open] YUI Autocomplete form element type

benjaminhill at gmail dot com — 2007-01-22T21:08:18+00:00

HTML_QuickForm2 Feature/Change Request
Reported by benjaminhill@...
2007-01-22T21:08:18+00:00
PHP: 5.1.0 OS: WinXP Package Version: CVS

Description:
------------
It would be very slick to have a subclass of the "input" form element type that supported the YUI AutoComplete library.
(Which is, I believe, BSD, so it should be ok?)

http://developer.yahoo.com/yui/autocomplete/

HTML_QuickForm2: Feature/Change Request 8626 [Open] new subtype: ximage for

b_j at tar dot hu — 2006-09-04T11:22:13+00:00

HTML_QuickForm2 Feature/Change Request
Reported by b_j@...
2006-09-03T14:16:12+00:00
PHP: Irrelevant OS:  Package Version: 3.2.6

Description:
------------
HTML/QuickForm/ximage.php:
HTML_QuickForm_element($elementName, null, $attributes);
			$this->setSource($src);
			$this->setType('ximage');
		}
		function setType($type){
			$this->_type = $type;
			//$this->updateAttributes(array('type'=>$type));
		} // end func setType
		function setSource($src){
				$this->updateAttributes(array('src' => $src));
		} // end func setSource
		function setBorder($border){
				$this->updateAttributes(array('border' => $border));
		} // end func setBorder
		function setAlign($align){
				$this->updateAttributes(array('align' => $align));
		} // end func setAlign
		function setHeight($height){
			$this->updateAttributes(array('height' => $height));
		}
		function setWidth($width){
			$this->updateAttributes(array('width' => $width));
		}
		function freeze(){
			return false;
		} //end func freeze
		function toHtml(){
			$this->setType(null);
			return 'getAttributes(true) . ' />';
		}
		function getFrozenHtml(){
			return $this->toHtml();
		}
		function setName($name){
			$this->updateAttributes(array('name' => $name));
		}
		function getName(){
			return $this->getAttribute('name');
		}


}
?>
HTML/QuickForm.php:
....
//Hungarian translation:
	var $_jsPrefix = 'Rossz adat';
	var $_jsPostfix = 'JavÃtani kell ezt az adatot';
	var $_requiredNote = '*'.
		' KÃ¶telezÃµ mezÃµ';
....
$GLOBALS['HTML_QUICKFORM_ELEMENT_TYPES'] = 
				array(
						'group'         =>array('HTML/QuickForm/group.php','HTML_QuickForm_group'),
						'hidden'        =>array('HTML/QuickForm/hidden.php','HTML_QuickForm_hidden'),
						'reset'         =>array('HTML/QuickForm/reset.php','HTML_QuickForm_reset'),
						'checkbox'      =>array('HTML/QuickForm/checkbox.php','HTML_QuickForm_checkbox'),
						'file'          =>array('HTML/QuickForm/file.php','HTML_QuickForm_file'),
            'image'         =>array('HTML/QuickForm/image.php','HTML_QuickForm_image'),
						'password'      =>array('HTML/QuickForm/password.php','HTML_QuickForm_password'),
						'radio'         =>array('HTML/QuickForm/radio.php','HTML_QuickForm_radio'),
						'button'        =>array('HTML/QuickForm/button.php','HTML_QuickForm_button'),
						'submit'        =>array('HTML/QuickForm/submit.php','HTML_QuickForm_submit'),
						'select'        =>array('HTML/QuickForm/select.php','HTML_QuickForm_select'),
						'hiddenselect'  =>array('HTML/QuickForm/hiddenselect.php','HTML_QuickForm_hiddenselect'),
						'text'          =>array('HTML/QuickForm/text.php','HTML_QuickForm_text'),
						'textarea'      =>array('HTML/QuickForm/textarea.php','HTML_QuickForm_textarea'),
						'link'          =>array('HTML/QuickForm/link.php','HTML_QuickForm_link'),
						'advcheckbox'   =>array('HTML/QuickForm/advcheckbox.php','HTML_QuickForm_advcheckbox'),
						'date'          =>array('HTML/QuickForm/date.php','HTML_QuickForm_date'),
						'static'        =>array('HTML/QuickForm/static.php','HTML_QuickForm_static'),
						'header'        =>array('HTML/QuickForm/header.php', 'HTML_QuickForm_header'),
						'html'          =>array('HTML/QuickForm/html.php', 'HTML_QuickForm_html'),
						'hierselect'    =>array('HTML/QuickForm/hierselect.php', 'HTML_QuickForm_hierselect'),
						'autocomplete'  =>array('HTML/QuickForm/autocomplete.php', 'HTML_QuickForm_autocomplete'),
						'xbutton'       =>array('HTML/QuickForm/xbutton.php','HTML_QuickForm_xbutton'),
						//BJ
						'ximage'        =>array('HTML/QuickForm/ximage.php','HTML_QuickForm_ximage')
				);
....

HTML_QuickForm2: Feature/Change Request 8318 [Open] new feature using validate_ptBR

jesus at evasta dot com dot br — 2006-09-04T11:23:20+00:00

HTML_QuickForm2 Feature/Change Request
Reported by jesus@...
2006-07-28T15:22:12+00:00
PHP: 4.4.2 OS: Linux - Suse Package Version: 3.2.6

Description:
------------
i created a validation class for quick_form
The class extends "HTML_QuickForm_Rule" the same of Email, Range, Regex...
"phone number" function is not implemented

Test script:
---------------
http://www.fo.ufu.br/Jesus/Testes/testes_brazilian/Brazilian.php
http://www.fo.ufu.br/Jesus/Testes/testes_brazilian/Brazilian2.php
http://www.fo.ufu.br/Jesus/Testes/testes_brazilian/form_validate.php

Expected result:
----------------
the same of validation_ptBR

Actual result:
--------------
the same of validation_ptBR
only "phone number" not

HTML_QuickForm2: Feature/Change Request 8060 [Open] HTML_QuickForm_select -> loadDbResult Support MDB2

dvilches at gmail dot com — 2006-10-06T10:45:36+00:00

HTML_QuickForm2 Feature/Change Request
Reported by dvilches@...
2006-06-28T11:47:54+00:00
PHP: Irrelevant OS: Irrelevant Package Version: 3.2.6

Description:
------------
I changed the method loadDbResult in HTML_QuickForm_select.

Test script:
---------------
require_once 'MDB2.php';
$dsn = array('phptype'  => DB_PHPTYPE,
	     'username' => DB_USER,
	     'password' => DB_PWD,
	     'hostspec' => DB_HOST,
	     'database' => DB_DATABASE,
					); 
$db = MDB2::factory($dsn); 
if (Pear::isError($db)){
    die($db->getMessage());
}
$db->setFetchMode(MDB2_FETCHMODE_ASSOC);

$sql  = "Select table_id, descrip From table";
$element = &HTML_QuickForm::createElement('select', 'table_id', 'Descrip');
$result = $db->query($sql);	
$element->addOption('','');
$element->loadDbResult($result, 'descrip', 'table_id');		$element->toHtml();	


The change of this method is:

if (!is_object($result) || !is_a($result, 'db_result')) {
....

by

if (!is_object($result) || (!is_a($result, 'db_result') && !is_a($result, 'mdb2_result'))) {
...

And works for me...


Expected result:
----------------


Actual result:
--------------

HTML_QuickForm2: Feature/Change Request 7432 [Analyzed] Client side validation

gdalle at cg06 dot fr — 2006-06-18T15:14:55+00:00

HTML_QuickForm2 Feature/Change Request
Reported by gdalle@...
2006-04-20T03:27:14+00:00
PHP: 4.3.10 OS: Win Xp Package Version: 3.2.5

Description:
------------
I've added a rule to an hidden element of the form. The rule calls a JavaScript function who check the validation.  
When the value of the element is empty, the JS validation function isn't called.
Is there a way to force the calling of this function ?

I can modify the JavaScript generated code by updating the Callback.php file (QuickForm/Rule) but it's not "clean". Is there an another way ?

Test script:
---------------
Here is my code :

$oSelect =& $oQuickForm->addElement("hidden","ID_CATEGORIE_LIST","");
$oQuickForm->registerRule("checkCategorie","callback","checkCategorie");
$oQuickForm->addRule("ID_CATEGORIE_LIST","bla bla bla","checkCategorie",null,"client");

Here is the JavaScript generated code :  

value = frm.elements['ID_CATEGORIE_LIST'].value;
if (value != '' && !checkCategorie(value) && !errFlag['ID_CATEGORIE_LIST']) {
  errFlag['ID_CATEGORIE_LIST'] = true;
  _qfMsg = _qfMsg + '\n bla bla bla';
}


Expected result:
----------------
The JS validation function should be executed.

Actual result:
--------------
The JavaScript validation function isn't executed because the generated code don't call the JavaScript validation function if the value of the element is empty.

HTML_QuickForm2: Feature/Change Request 5957 [Open] date Element: offer only a range of months

pav at FreeBSD dot org — 2006-06-08T08:53:46+00:00

HTML_QuickForm2 Feature/Change Request
Reported by pav@...
2005-11-14T09:02:32+00:00
PHP: 4.4.1 OS: FreeBSD Package Version: 

Description:
------------
Add the new options to the date Element: minMonth, maxMonth. Works just like minYear and maxYear - it limits the range of months offered in the form to the user.

Test script:
---------------
The patch against CVS head is at

http://raven.oook.cz/date-monthrange.diff

HTML_QuickForm2: Feature/Change Request 5558 [Analyzed] Use setlocale to determine language

themars at users dot sourceforge dot net — 2006-06-08T08:25:57+00:00

HTML_QuickForm2 Feature/Change Request
Reported by themars@...
2005-09-29T07:01:42+00:00
PHP: Irrelevant OS: Irrelevant Package Version: 

Description:
------------
The HTML_QuickForm_Date element ignores the locale set by
    setlocale(LC_TIME, $myLocale);
Why don't you use that locale if the language property is not explicitly set?
If you use the strftime function instead of the date function in the setValue method, you can support it.

Test script:
---------------
Change the default of the language property to "default":
    line 72
    line 267

Change the line (425):
    $arr = explode('-', date('w-d-n-Y-h-H-i-s-a-A-W', (int)$value));

into:
    if ($this->_options['language'] == 'default') {
        $arr = explode('-', strftime('%w-%d-%m-%Y-%I-%H-%M-%S-%p-%p-%V', (int)$value));
        $arr[2] = preg_replace('#^0#', '', $arr[2]);
        $arr[9] = strtoupper($arr[9]);
    } else {
        $arr = explode('-', date('w-d-n-Y-h-H-i-s-a-A-W', (int)$value));
    }

Expected result:
----------------
if the user does not specify a language, the language specified with setlocale or otherwise the system default language is used. If specified and found, the class behaves as before.

Actual result:
--------------
The language set by setlocale is ignored.

HTML_QuickForm2: Feature/Change Request 5308 [Open] Javascript Validation with Ajax

maarten at xolphin dot nl — 2006-06-08T08:24:45+00:00

HTML_QuickForm2 Feature/Change Request
Reported by xolphin
2005-09-06T04:29:50+00:00
PHP: Irrelevant OS: Irrelevant Package Version:

Description:
------------
At the moment HTML_QuickForm uses some Javascript validation if wanted on the OnSubmit of the form. This saves some time checking the form on the server, but it looks nasty. The user has to read the alert created by the JavaScript, and has to find the form element where the error is in.

Ajax is a development methodology focused on removing click and wait in web applications. I won't explain it here, because there is already a lot of information available on it.

I think Ajax can be used in HTML_QuickForm very good. With Ajax we could get the folowing advantages:

- Validation code only has to be written ones, and is executed on the server (without the need to submit anything). We don't need a php validation seperate from a javascript validation anymore.
- Code can be checked realtime, while the user is filling in the form. He can instantly see he has done something wrong. Of course this can be made with normal JavaScript too, but Ajax makes it some easier.
- Auto completion can be done with realtime data, instead of auto completion with static data which is already possible now.

A nice example of what can be done with Ajax can be found on http://www.khelder.com/tutorials/smartvalidation/ . For better clarification the form elements with errors can be colored for example yellow or orange. But that is up to the developer.

I hope this is the right place to make such a suggestion, if this is better of in another place, please let me know. I like the Ajax idea a lot and if needed I am willing to code it into HTML_QuickForm. Below some useful links with more info of Ajax.

Validation with Ajax:
http://particletree.com/features/smart-validation-with-ajax

Ajax information:
http://www.sergiopereira.com/articles/prototype.js.html

How Ajax works:
http://www.adaptivepath.com/publications/essays/archives/000385.php

Ways to implement it:
http://particletree.com/features/a-guide-to-unobtrusive-javascript

Pear implementation:
http://blog.joshuaeichorn.com/HTML_AJAX

HTML_QuickForm2: Feature/Change Request 4697 [Open] addRule() - word count

pioneer at daweb dot net — 2006-06-08T08:21:59+00:00

HTML_QuickForm2 Feature/Change Request
Reported by pioneer@...
2005-06-28T10:25:11+00:00
PHP: Irrelevant OS:  Package Version: 

Description:
------------
I'd like to request a "wordcount" rule for both client and server side processing.  This would be useful for textareas where word counts are critical.

HTML_QuickForm2: Feature/Change Request 4268 [Open] Use of strspn() and strcspn() functions

2007-07-17T14:34:39+00:00

HTML_QuickForm2 Feature/Change Request
Reported by jausions
2005-05-03T08:45:28+00:00
PHP: Irrelevant OS: Irrelevant Package Version: 

Description:
------------
For the lettersonly, alphanumeric and nopunctuation rules, I suggest to use the PHP strspn() and strcspn() function instead of heavy weight regexp.

By the way, is it intentional that not all punctuation characters are in the list of forbidden characters? Missing from the list are: ` & - ;



Reproduce code:
---------------
In HTML_QuickForm_Rule_Regexp

name) {
            case 'lettersonly':
            case 'alphanumeric':
            case 'nopunctuation':
                switch ($this->name) {
                    case 'lettersonly':
                        $str = 'abcdefghijklmnopqrstuvwxyz';
                        $function = 'strspn';
                        break;
                    case 'alphanumeric':
                        $str = 'abcdefghijklmnopqrstuvwxyz0123456789';
                        $function = 'strspn';
                        break;
                    case 'nopunctuation':
                        $str = '().`;\\|/*^?#!@$&%+=-,"\'><~[]{}';
                        $function = 'strcspn';
                        break;
                }
                return (strlen($value) != $function(strtolower($value, $str))) ? false : true;
                break;
        }
        if (isset($this->_data[$this->name])) {
            if (!preg_match($this->_data[$this->name], $value)) {
                return false;
            }
        } else {
            if (!preg_match($regex, $value)) {
                return false;
            }
        }
        return true;
    } // end func validate
?>

HTML_QuickForm2: Feature/Change Request 4061 [Open] Support max/min hours in time controls

mail at simonellistonball dot com — 2006-06-08T08:16:31+00:00

HTML_QuickForm2 Feature/Change Request
Reported by mail@...
2005-04-05T05:52:55+00:00
PHP: 4.3.10 OS: n/a Package Version: 

Description:
------------
It would be helpful to implement something like the maxYear and minYear options for time fields (hours) so the control can be limited to (for example) time in a working day.

HTML_QuickForm2: Feature/Change Request 2535 [Open] Getting a list of element names and their rules

strauchdieb at gmx dot de — 2006-06-08T08:16:58+00:00

HTML_QuickForm2 Feature/Change Request
Reported by strauchdieb@...
2004-10-15T08:51:26+00:00
PHP: Irrelevant OS: Irrelevant Package Version: 

Description:
------------
I want to retrieve the element names as an array. I wrote a method getElementNames() that returns the keys of $_elementIndex

This is especially useful in addition to the new insertElementBefore function.

Furthermore I want to get a list of rules for each element. For this I wrote the method getElementRules() that returns the $_rules array. 

I made a diff patch with the current stable version of HTML_QuickForm. You can see it at
http://www.gildehaus-hannover.de/QuickForm.diff