http://pear.php.net/bugs/search.php?cmd=display&package_name%5B0%5D=File_MARC Search Results en-us pear-webmaster@lists.php.net pear-webmaster@lists.php.net hourly 1 2000-01-01T12:00+00:00 http://pear.php.net/gifs/pearsmall.gif http://pear.php.net/bugs http://pear.php.net/bugs/21246 File_MARC Bug Reported by danmichaelo 2017-10-08T21:40:54+00:00 PHP: 5.6.31 OS: macOS 10.13 Package Version: 1.1.5 Description: ------------ Removing multiple subfields using deleteSubfield does not work as expected. The problem is that the method doesn't call $n->setPosition($pos) on the subfields that follow the removed field. I wasn't familiar with the SplDoublyLinkedList structure from before, but I tried cooking together a patch that at least solves my issue. Test script: --------------- require 'vendor/autoload.php'; require 'File/MARC/Data_Field.php'; $field = new File_MARC_Data_Field(650, [ new File_MARC_Subfield('9', 'test1'), new File_MARC_Subfield('9', 'test2'), new File_MARC_Subfield('0', 'test3'), new File_MARC_Subfield('9', 'test4'), ]); echo "--- Before: ---\n$field\n\n"; foreach ($field->getSubfields('9') as $subfield) { echo "Deleting subfield: $subfield\n"; $field->deleteSubfield($subfield); } echo "\n--- After: ---\n$field\n\n"; Expected result: ---------------- --- Before: --- 650 _9test1 _9test2 _0test3 _9test4 Deleting subfield: [9]: test1 Deleting subfield: [9]: test2 Deleting subfield: [9]: test4 --- After: --- 650 _0test3 Actual result: -------------- --- Before: --- 650 _9test1 _9test2 _0test3 _9test4 Deleting subfield: [9]: test1 Deleting subfield: [9]: test2 Deleting subfield: [9]: test4 --- After: --- 650 _9test2 _9test4]]> File_MARC Bug Reported by danmichaelo 2017-10-08T21:40:54+00:00 PHP: 5.6.31 OS: macOS 10.13 Package Version: 1.1.5 Description: ------------ Removing multiple subfields using deleteSubfield does not work as expected. The problem is that the method doesn't call $n->setPosition($pos) on the subfields that follow the removed field. I wasn't familiar with the SplDoublyLinkedList structure from before, but I tried cooking together a patch that at least solves my issue. Test script: --------------- require 'vendor/autoload.php'; require 'File/MARC/Data_Field.php'; $field = new File_MARC_Data_Field(650, [ new File_MARC_Subfield('9', 'test1'), new File_MARC_Subfield('9', 'test2'), new File_MARC_Subfield('0', 'test3'), new File_MARC_Subfield('9', 'test4'), ]); echo "--- Before: ---\n$field\n\n"; foreach ($field->getSubfields('9') as $subfield) { echo "Deleting subfield: $subfield\n"; $field->deleteSubfield($subfield); } echo "\n--- After: ---\n$field\n\n"; Expected result: ---------------- --- Before: --- 650 _9test1 _9test2 _0test3 _9test4 Deleting subfield: [9]: test1 Deleting subfield: [9]: test2 Deleting subfield: [9]: test4 --- After: --- 650 _0test3 Actual result: -------------- --- Before: --- 650 _9test1 _9test2 _0test3 _9test4 Deleting subfield: [9]: test1 Deleting subfield: [9]: test2 Deleting subfield: [9]: test4 --- After: --- 650 _9test2 _9test4]]> 2017-12-04T09:55:30+00:00 danmichaelo &#x61;&#116; gmail &#x64;&#111;&#x74; com File_MARC Bug http://pear.php.net/bugs/21235 File_MARC Bug Reported by surfrdan 2017-08-18T11:24:56+00:00 PHP: 5.5.38 OS: Package Version: 1.1.5 Description: ------------ in the toXML() function within MARC/Record.php it strikes me that the argument $single should return a MARCXML document without the collection element but the reverse is true. Is this expected?]]> File_MARC Bug Reported by surfrdan 2017-08-18T11:24:56+00:00 PHP: 5.5.38 OS: Package Version: 1.1.5 Description: ------------ in the toXML() function within MARC/Record.php it strikes me that the argument $single should return a MARCXML document without the collection element but the reverse is true. Is this expected?]]> 2017-08-18T11:24:56+00:00 dof &#x61;&#116; llgc &#x64;&#111;&#x74; org &#x64;&#111;&#x74; uk File_MARC Bug http://pear.php.net/bugs/21219 File_MARC Bug Reported by aroussos 2017-06-15T19:01:37+00:00 PHP: 5.6.30 OS: Debian (jessie) Package Version: 1.1.5 Description: ------------ We recently discovered that a number of authority records in our Koha ILS installation have the following glitch: an extra space character (" ") appears at the end of the MARC leader. I wrote a simple script that uses PHP's rtrim() to remove the trailing whitespace, however the toXML() call at the end of my script appears to modify the leader by inserting the string "na" at positions 05 and 06. Is this intentional? Test script: --------------- As per the bug submission guidelines, my test script is longer than 20 lines of code, so here's a link to it: https://pastebin.com/GbqVWdcb Expected result: ---------------- <?xml version="1.0" encoding="UTF-8"?> <collection xmlns="http://www.loc.gov/MARC21/slim"> <record> <leader>00143 2200073 4500</leader> <controlfield tag="001">260</controlfield> <datafield tag="100" ind1=" " ind2=" "> <subfield code="a">20120402afrey50 ba0</subfield> </datafield> <datafield tag="152" ind1=" " ind2=" "> <subfield code="b">PERSO_NAME</subfield> </datafield> <datafield tag="200" ind1=" " ind2=" "> <subfield code="a">Severin</subfield> <subfield code="b">Georgii</subfield> </datafield> </record> </collection> Actual result: -------------- <?xml version="1.0" encoding="UTF-8"?> <collection xmlns="http://www.loc.gov/MARC21/slim"> <record> <leader>00143na 2200073 4500</leader> <controlfield tag="001">260</controlfield> <datafield tag="100" ind1=" " ind2=" "> <subfield code="a">20120402afrey50 ba0</subfield> </datafield> <datafield tag="152" ind1=" " ind2=" "> <subfield code="b">PERSO_NAME</subfield> </datafield> <datafield tag="200" ind1=" " ind2=" "> <subfield code="a">Severin</subfield> <subfield code="b">Georgii</subfield> </datafield> </record> </collection>]]> File_MARC Bug Reported by aroussos 2017-06-15T19:01:37+00:00 PHP: 5.6.30 OS: Debian (jessie) Package Version: 1.1.5 Description: ------------ We recently discovered that a number of authority records in our Koha ILS installation have the following glitch: an extra space character (" ") appears at the end of the MARC leader. I wrote a simple script that uses PHP's rtrim() to remove the trailing whitespace, however the toXML() call at the end of my script appears to modify the leader by inserting the string "na" at positions 05 and 06. Is this intentional? Test script: --------------- As per the bug submission guidelines, my test script is longer than 20 lines of code, so here's a link to it: https://pastebin.com/GbqVWdcb Expected result: ---------------- <?xml version="1.0" encoding="UTF-8"?> <collection xmlns="http://www.loc.gov/MARC21/slim"> <record> <leader>00143 2200073 4500</leader> <controlfield tag="001">260</controlfield> <datafield tag="100" ind1=" " ind2=" "> <subfield code="a">20120402afrey50 ba0</subfield> </datafield> <datafield tag="152" ind1=" " ind2=" "> <subfield code="b">PERSO_NAME</subfield> </datafield> <datafield tag="200" ind1=" " ind2=" "> <subfield code="a">Severin</subfield> <subfield code="b">Georgii</subfield> </datafield> </record> </collection> Actual result: -------------- <?xml version="1.0" encoding="UTF-8"?> <collection xmlns="http://www.loc.gov/MARC21/slim"> <record> <leader>00143na 2200073 4500</leader> <controlfield tag="001">260</controlfield> <datafield tag="100" ind1=" " ind2=" "> <subfield code="a">20120402afrey50 ba0</subfield> </datafield> <datafield tag="152" ind1=" " ind2=" "> <subfield code="b">PERSO_NAME</subfield> </datafield> <datafield tag="200" ind1=" " ind2=" "> <subfield code="a">Severin</subfield> <subfield code="b">Georgii</subfield> </datafield> </record> </collection>]]> 2017-06-16T13:45:50+00:00 arouss1980 &#x61;&#116; gmail &#x64;&#111;&#x74; com File_MARC Bug