PEAR Bug Search Results

File_CSV: Bug 15123 [Open] Broken CSV unit tests

daniel dot oconnor at gmail dot com — 2009-08-12T21:20:35+00:00

File_CSV Bug
Reported by doconnor
2008-11-21T22:23:54+00:00
PHP: 5.2.6 OS:  Package Version: 

Description:
------------
Take a look at http://www.lauken.com/doconnor/results.txt

File/tests/CSV/033.phpt
File/tests/CSV/034.phpt

are currently broken

Test script:
---------------
pear run-tests tests/CSV/

Expected result:
----------------
Tests pass

Actual result:
--------------
18) /home/clockwerx/pear/File/tests/CSV/033.phpt
--- Expected
+++ Actual
@@ -17,7 +17,7 @@
             [3] => a"b
             [4] => 4
         )
-    
+
     [1] => Array
         (
             [0] => 1
@@ -26,14 +26,14 @@
             [3] => 3
             [4] => 
         )
-        
+
     [2] => Array
         (
             [0] => 1
             [1] => 2
-            [2] => ,","
-            [3] => 4
-            [4] => ,
+            [2] => 
+            [3] => 
+            [4] => ",4,
         )
 
 )
\ No newline at end of file


19) /home/clockwerx/pear/File/tests/CSV/034.phpt
--- Expected
+++ Actual
@@ -16,21 +16,21 @@
             [2] => 3
             [3] => 4
         )
-    
+
     [1] => Array
         (
             [0] => 1
             [1] => 2
-            [2] => ,
-            [3] => 4
+            [2] => 
+            [3] => 
         )
-        
+
     [2] => Array
         (
             [0] => 1
             [1] => 2
             [2] => 3
-            [3] => ,
+            [3] => 
         )
 
 )
\ No newline at end of file

File_CSV: Feature/Change Request 12276 [Open] allow php:// files

cweiske at php dot net — 2007-10-19T00:59:51+00:00

File_CSV Feature/Change Request
Reported by cweiske
2007-10-19T00:59:51+00:00
PHP: 5.2.4 OS:  Package Version: CVS

Description:
------------
Currently it is not possible to use File_CSV to directly write to php://output or php://stdout since the protocol is stripped out in File.php.

If you have an application that creates downloadable CSV files, you probably want to directly output it to the browser instead of writing it to disk first.

File_CSV: Feature/Change Request 12275 [Open] Allow using file pointers directly

cweiske at php dot net — 2007-10-19T00:58:06+00:00

File_CSV Feature/Change Request
Reported by cweiske
2007-10-19T00:58:06+00:00
PHP: 5.2.4 OS:  Package Version: CVS

Description:
------------
It would be very helpful if one could directly use file handles instead of always having to pass a file name.

This is especially needed when writing CSV into an already open file.

File_CSV: Feature/Change Request 7742 [Open] CSV string parsing

olivier at samalyse dot com — 2007-08-11T16:14:05+00:00

File_CSV Feature/Change Request
Reported by olivierg
2006-05-28T17:57:08+00:00
PHP: 4.4.2 OS: Debian Package Version: 

Description:
------------
Could you please add a feature to parse a string that contains CSV data.

Like : $array = File_CSV::parse($string);

I know this is not really about files, but it concerns CSV.

I need it and am about to copy/paste some of your parsing routines into my code, which is not the best thing IMO.

File_CSV: Bug 5652 [Assigned] Static $config causes error with several CSV-objects

blinky at gmx dot net — 2007-08-11T16:13:53+00:00

File_CSV Bug
Reported by blinky@...
2005-10-10T17:51:49+00:00
PHP: 4.3.10 OS: Linux 2.6.12 Package Version: 

Description:
------------
With several objects based upon File_CSV there will be problems in loops with read() and write() calls when they have different configuration (5 vs. 42 fields).


Test script:
---------------
$csvFile = new File_CSV();
$outFile = new File_CSV();

$csvfileformat = $csvFile->discoverFormat($csvfilename);
$csvoutformat = array('fields' => 5, 'sep' => ';', 'quote' => '"');

while ($csv_line = $csvFile->read($csvfilename, $csvfileformat)) {
$outarray[] = $csv_line[0]; $outarray[] = $csv_line[1]; $outarray[] = $csv_line[23]; $outarray[] = $csv_line[33];
$outarray[] = $csv_line[43];

$outFile->write($outfilename, $outarray, $csvoutformat);

}


Bugfix description below.

Expected result:
----------------
The first line in the output file will contain 5 fields with the correct value. The second line (after the first call of write() with the other configuration) will only contain the first and second value since read() only reads 5 fields instead of 42.

I could fix this problem by changing the file CSV.php like this:

1. Adding "var $config;" after "class File_CSV {"
2. In function "getPointer" I removed "static $config".
3. In "getPointer" I replaced "$config" by "$this->config". (near lines 138 and 148)

File_CSV: Feature/Change Request 3935 [Assigned] File_CSV::read should optionally ignore field count

crain at fuse dot net — 2007-08-11T16:13:39+00:00

File_CSV Feature/Change Request
Reported by crain@...
2005-03-23T18:29:05+00:00
PHP: 4.3.9 OS: Win XP Package Version: 

Description:
------------
Hi,

I would like to see an optional third parameter to File_CSV::read() to instruct the method whether or not to ignore lines with more or fewer fields than calculated by File_CSV::discoverFormat(), e.g. function read($file, &$conf, $ignoreSize = false).

Currently, the test at the end of the method results in valid csv data not being returned to the calling script, even though a valid csv file may have lines having varying numbers of elements. If the exploded pieces of a line <> $conf['fields']  (which, being based only on the first five lines of a file, should be only a guideline in any case) the parsed line is not returned.

The current behavior breaks PEAR::Contact_AddressBook::importFromFile(), which relies on File_CSV::read() for parsing csv exports from contact managers, which very typically export files of varying numbers of fields. I think it should be up to the calling script to determine how to respond to a mismatch in size.

Thanks!
Andy Crain